This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Don’t close or change tabs in the renderer. The renderer should reque… #8782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
force-pushed
the
tab-close-activate
branch
from
14133b8
to
138680d
Compare
…st the changes and respond to them when the browser process updates
bridiver
force-pushed
the
tab-close-activate
branch
from
1f95f64
to
499546c
Compare
bridiver
force-pushed
the
tab-close-activate
branch
from
9067d56
to
57a853c
Compare
bridiver
force-pushed
the
tab-close-activate
branch
from
c847ac6
to
1c1239c
Compare
|
Merging now since Muon 3.0.100 has been merged... let's review and address feedback in a follow up 😄 |
This was referenced May 10, 2017
kspearrin
pushed a commit
to kspearrin/browser-laptop
that referenced
this pull request
May 11, 2017
…perty 'get' of null" errors during tear off tab after brave#8782 Auditors: @bridiver
|
This PR removes the browser app action Which is OK, but the old Which is why #45 regressed. |
|
I'll re-add it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st the changes and respond to them when the browser process updates
REQUIRES muon 3.0.100
Test Plan:
This covers quite a lot of uses, but in general closing tabs, switching tabs and lazy loaded tabs will be affected the most
https://github.com/brave/browser-laptop/wiki/Manual-Tests#bookmarks
https://github.com/brave/browser-laptop/wiki/Manual-Tests#context-menus
https://github.com/brave/browser-laptop/wiki/Manual-Tests#tabs-pinning-and-tear-off-tabs
https://github.com/brave/browser-laptop/wiki/Manual-Tests#find-on-page
https://github.com/brave/browser-laptop/wiki/Manual-Tests#zoom