Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

autoplay block shouldn't weigh in once users start playing media #8897

Closed
darkdh opened this issue May 17, 2017 · 1 comment · Fixed by brave/muon#264
Closed

autoplay block shouldn't weigh in once users start playing media #8897

darkdh opened this issue May 17, 2017 · 1 comment · Fixed by brave/muon#264
Assignees
@darkdh
Labels
feature/autoplay QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.19.x (Beta Chan...

Comments

@darkdh
Copy link
Member

darkdh commented May 17, 2017

STR:

  1. Go to https://vimeo.com/215927968
  2. Click no and remember this action when autoplay notification prompt
  3. Start playing video and drag the progress bar

may-16-2017 17-37-00
@darkdh darkdh added this to the 0.15.300 milestone May 17, 2017
@darkdh darkdh self-assigned this May 17, 2017
darkdh added a commit to brave/muon that referenced this issue May 17, 2017
@darkdh
autoplay block no longer conflicts with timeline change pause
4e62d71 
fix brave/browser-laptop#8897

Auditors: @bridiver, @bbondy
@darkdh darkdh mentioned this issue May 17, 2017
Closed
@darkdh darkdh modified the milestones: 0.15.400, 0.15.300 May 18, 2017
@darkdh
Copy link
Member Author

darkdh commented May 22, 2017

#8739 (comment)

@luixxiul luixxiul mentioned this issue May 23, 2017
Closed
4 tasks
@alexwykoff alexwykoff removed this from the 0.16.100 milestone May 23, 2017
darkdh added a commit to brave/muon that referenced this issue Jul 26, 2017
@darkdh
Don't check autoplay setting when play is trigger by user gesture
501dac2 
fix brave/browser-laptop#8897

Auditors: @bridiver, @bsclifton
@darkdh darkdh mentioned this issue Jul 26, 2017
Merged
@darkdh darkdh added this to the 0.20.x (Nightly Channel) milestone Jul 26, 2017
darkdh added a commit to brave/muon that referenced this issue Aug 3, 2017
@darkdh
Don't check autoplay setting when play is trigger by user gesture
89c3251 
fix brave/browser-laptop#8897

Auditors: @bridiver, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Aug 3, 2017
@darkdh
Don't check autoplay setting when play is trigger by user gesture
e9b6002 
fix brave/browser-laptop#8897

Auditors: @bridiver, @bsclifton
darkdh added a commit to brave/muon that referenced this issue Aug 4, 2017
@darkdh
Don't check autoplay setting when play is trigger by user gesture
6a4e932 
fix brave/browser-laptop#8897

Auditors: @bridiver, @bsclifton
@darkdh darkdh modified the milestones: 0.19.x (Beta Channel), 0.20.x (Developer Channel) Aug 16, 2017
This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul changed the title autoplay block shouldn't weigh in once users start playing media autoplay block shouldn't weigh in once users start playing media Sep 20, 2017
This was referenced Sep 20, 2017
Closed
Closed
Closed
This was referenced Sep 21, 2017
Closed
Closed
This was referenced Sep 25, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
bridiver pushed a commit to brave/muon that referenced this issue Oct 4, 2017
@darkdh @bridiver
Don't check autoplay setting when play is trigger by user gesture
d4d21fc 
fix brave/browser-laptop#8897

Auditors: @bridiver, @bsclifton
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
@kjozwiak kjozwiak mentioned this issue Oct 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/autoplay QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.19.x (Beta Channel)
5 participants
@alexwykoff @luixxiul @darkdh @srirambv @LaurenWags