This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Don't check autoplay setting when play is trigger by user gesture #264
+51
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
5.0 is the correct milestone for this? |
|
because 4.4.4 has been released so I chose the next available milestone. |
7 tasks
bridiver
reviewed
Aug 3, 2017
patches/master_patch.patch
Outdated
| presentation_receiver(false), | ||
| media_controls_enabled(true), | ||
| do_not_update_selection_on_mutating_selection_range(false), | ||
| -#if defined(OS_ANDROID) |
There was a problem hiding this comment.
can you set these with MUON_CHROMIUM_BUILD?
darkdh
force-pushed
the
autoplay_refactor
branch
2 times, most recently
from
89c3251
to
e9b6002
Compare
bridiver
reviewed
Aug 4, 2017
patches/master_patch.patch
Outdated
| media_controls_enabled(true), | ||
| do_not_update_selection_on_mutating_selection_range(false), | ||
| -#if defined(OS_ANDROID) | ||
| +#if defined(OS_ANDROID) || defined(MUON_CHROMIUM_BUILD) |
There was a problem hiding this comment.
MUON_CHROMIUM_BUILD is not defined for our builds, it is only defined when building Chromium. Is that correct here?
There was a problem hiding this comment.
the name is probably a little confusing, the MUON_ is just a prefix
There was a problem hiding this comment.
Oh, I was confused by the prefix. And it has the opposite behavior
darkdh
force-pushed
the
autoplay_refactor
branch
from
e9b6002
to
6a4e932
Compare
bridiver
approved these changes
Aug 4, 2017
bridiver
added a commit
that referenced
this pull request
Aug 4, 2017
Don't check autoplay setting when play is trigger by user gesture
bridiver
added a commit
that referenced
this pull request
Aug 4, 2017
Don't check autoplay setting when play is trigger by user gesture
bridiver
added a commit
that referenced
this pull request
Aug 4, 2017
Don't check autoplay setting when play is trigger by user gesture
bridiver
added a commit
that referenced
this pull request
Aug 4, 2017
Don't check autoplay setting when play is trigger by user gesture
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/browser-laptop#8897
Auditors: @bridiver, @bsclifton