Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Windows only - Bookmarks toolbar - Bookmark hover targets are pushed down if there are no tabs below the folder #9088

Closed
alexwykoff opened this issue May 27, 2017 · 26 comments
Closed

Windows only - Bookmarks toolbar - Bookmark hover targets are pushed down if there are no tabs below the folder #9088

alexwykoff opened this issue May 27, 2017 · 26 comments
Assignees
@jonathansampson @bsclifton
Labels
bug misc/drag-and-drop OS/Windows priority/P4 Minor loss of function. Workaround usually present.

Comments

@alexwykoff
Copy link
Contributor

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    A user from support reported that the highlight effect did not work as expected if there wasn't a tab underneath the bookmark folder.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Window

  • Brave Version (revision SHA):
    0.15.310

  • Steps to reproduce:

    1. Create quite a few bookmark folders and add bookmarks
    2. Check bookmark folders above a tab vs those which exist over no tab.
    3. Slowly hover over each option

  • Actual result:
    The bookmark or sub-folder did not highlight for folders without tabs beneath them. (It was later discovered the targets were pushed down to the last couple pixels of each first bookmark entry in the expansion menu.

  • Expected result:
    The bookmark or sub-folder should have a highlight style applied

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@alexwykoff alexwykoff added the bug label May 27, 2017
@alexwykoff alexwykoff added this to the 0.16.200 milestone May 27, 2017
@xjmzx
Copy link

xjmzx commented May 30, 2017 •
edited
Loading

Have a somewhat similar problem since last update to 0.15.310 on MacOS.

Bookmarks can no longer be dragged, dropped. Only created or deleted.

OS: Sierra 10.12.5 (16F73)

@eljuno
Copy link
Contributor

eljuno commented Jun 3, 2017

+1 from community

@eljuno
Copy link
Contributor

eljuno commented Jun 6, 2017

+1 from community

@alexwykoff alexwykoff assigned alexwykoff and unassigned alexwykoff Jun 13, 2017
@alexwykoff alexwykoff modified the milestones: 0.19.x (Nightly Channel), 0.18.x (Developer Channel) Jun 13, 2017
@alexwykoff alexwykoff self-assigned this Jun 13, 2017
@alexwykoff
Copy link
Contributor Author

@alexwykoff try to repro this plz 😸

@alexwykoff alexwykoff modified the milestones: 0.20.x (Developer Channel), 0.19.x (Beta Channel) Jul 18, 2017
@eljuno
Copy link
Contributor

eljuno commented Aug 14, 2017

+1 from community https://community.brave.com/t/unable-to-click-first-bookmark-in-a-folder-via-bookmark-bar/5803?u=eljuno

@NejcZdovc NejcZdovc mentioned this issue Aug 15, 2017
Closed
@NejcZdovc
Copy link
Contributor

+3 from #10323

@alexwykoff alexwykoff modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 15, 2017
@eljuno
Copy link
Contributor

eljuno commented Aug 15, 2017

+1 from community https://community.brave.com/t/favorite-bar-issue/5900?u=eljuno

@eljuno eljuno mentioned this issue Aug 19, 2017
Closed
@eljuno
Copy link
Contributor

eljuno commented Oct 6, 2017

+1 from community https://community.brave.com/t/bug-report-bookmarks-not-being-selected/8656?u=eljuno

@luixxiul
Copy link
Contributor

I suspect it is due to that the area is reserved for system context menu on Windows. @bsclifton might know well about that.

@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel), Backlog Oct 25, 2017
@alexwykoff alexwykoff added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Oct 31, 2017
@bbondy bbondy modified the milestones: Triage Backlog, Prioritized Backlog Nov 2, 2017
@bsclifton
Copy link
Member

+1 from #12097 (comment)

@jonathansampson
Copy link
Collaborator

jonathansampson commented Dec 4, 2017 •
edited
Loading

This does appear to rely on the mouse being within the region of the tab/new-tab elements below:

hit-regions
hit-regions-border

Looks like it may be identical/related to #9436 (comment).

@jonathansampson
Copy link
Collaborator

The problem here is collision with drag regions. These do not respect z-index, and thus take-over the mouse anytime you enter a the coordinates of a drag-region. In the above example, the entire tabStrip is draggable. The tabs and new-tab button are not, which allows you to hover bookmarks while in their drag region.

One solution is to temporarily remove the .allowDragging class from .tabStripContainer when a bookmark menu is opened, and restore the class once the bookmark menu has closed.

<span class="tabStripContainer allowDragging">...</span>

@LaurenWags
Copy link
Member

+1 from twitter: https://twitter.com/wwwmarty/status/944245295927394304

@eljuno
Copy link
Contributor

eljuno commented Jan 8, 2018

+1 from community https://community.brave.com/t/first-favourite-website-in-a-folder-is-clickable-only-on-a-first-pixel/13328?u=eljuno

@srirambv
Copy link
Collaborator

+2 from community https://community.brave.com/t/bookmark-bug-unable-to-click-the-first-bookmark/13996/2

@eljuno
Copy link
Contributor

eljuno commented Jan 18, 2018

+1 from community https://community.brave.com/t/bug-report-bookmark-bar-problem/13981?u=eljuno

@eljuno
Copy link
Contributor

eljuno commented Jan 20, 2018 •
edited
Loading

+1 from community https://community.brave.com/t/bookmark-folder/14350?u=eljuno
+1 from community https://community.brave.com/t/difficult-time-accessing-first-bookmark-within-bookmark-folders/14417?u=eljuno

@NejcZdovc
Copy link
Contributor

I think that we need to bump priority on this one @bsclifton

@eljuno
Copy link
Contributor

eljuno commented Jan 23, 2018

+1 from community https://community.brave.com/t/unclickable-bookmark-area/14652?u=eljuno

@NejcZdovc NejcZdovc modified the milestones: Backlog (Prioritized), 0.21.x (Developer Channel) Jan 23, 2018
@NejcZdovc
Copy link
Contributor

pulled into 0.21

@eljuno
Copy link
Contributor

eljuno commented Feb 8, 2018

Can't reproduced on latest stable version 0.20.30

Record:
first-bookmark-20-30

@jonathansampson
Copy link
Collaborator

jonathansampson commented Feb 13, 2018 •
edited
Loading

@elia The dropdown needs to overlap the tab and new-tab button. See the positions of the UI elements in this comment: #9088 (comment)

@NejcZdovc
Copy link
Contributor

pushing back to 0.22

@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.22.x (Developer Channel) Feb 14, 2018
@eljuno
Copy link
Contributor

eljuno commented Feb 14, 2018

@jonathansampson Still can't reproduce this on latest stable. 😄

first-bookmark-20-30-overlap

@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
@alexwykoff
Copy link
Contributor Author

@bsclifton @jonathansampson feel free to close if no repro thx

@alexwykoff alexwykoff added priority/P4 Minor loss of function. Workaround usually present. and removed priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). labels Mar 20, 2018
@bsclifton
Copy link
Member

Confirmed this works great using 0.21.18 on Windows 10 x64 😄 👍

@bsclifton bsclifton removed this from the 0.23.x (Developer Channel) milestone Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonathansampson jonathansampson

@bsclifton bsclifton

Labels
bug misc/drag-and-drop OS/Windows priority/P4 Minor loss of function. Workaround usually present.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@jonathansampson @bbondy @alexwykoff @xjmzx @luixxiul @bsclifton @NejcZdovc @srirambv @eljuno @LaurenWags