Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add test for new tab activation #9178

Closed
bsclifton opened this issue May 31, 2017 · 1 comment · Fixed by #9179
Closed

Add test for new tab activation #9178

bsclifton opened this issue May 31, 2017 · 1 comment · Fixed by #9179
Assignees
@bsclifton
Labels
automated-tests QA/no-qa-needed release-notes/exclude
Milestone
0.18.x Release

Comments

@bsclifton
Copy link
Member

Tests for code introduced with 0391096
@bsclifton bsclifton self-assigned this May 31, 2017
bsclifton added a commit that referenced this issue May 31, 2017
@bsclifton
Add tests for tab reducer => APP_TAB_CLOSED
a33e1d1 
Fixes #9178
@bsclifton bsclifton mentioned this issue May 31, 2017
Merged
7 tasks
@bsclifton
Copy link
Member Author

NOTE: this is a follow up for:
1a76ade
and
0338a03

bsclifton added a commit that referenced this issue May 31, 2017
@bsclifton
Add tests for tab reducer => APP_TAB_CLOSED
8eb2068 
Fixes #9178
bsclifton added a commit that referenced this issue Jun 1, 2017
@bsclifton
Test all branches for tabsReducer => APP_TAB_CLOSED
3443c48 
Fixes #9178

During this process, three issues were found/fixed:
- window was not being checked if truthy when closed
- tab close action NEXT was not being respected
- because getNextTabIdByIndex searches forward and backwards, the setting to first block was dead code (and was removed)
bsclifton added a commit that referenced this issue Jun 1, 2017
@bsclifton
Test all branches for tabsReducer => APP_TAB_CLOSED
6816bcd 
Fixes #9178

During this process, three issues were found/fixed:
- window was not being checked if truthy when closed
- tab close action NEXT was not being respected
- because getNextTabIdByIndex searches forward and backwards, the setting to first block was dead code (and was removed)
@bsclifton bsclifton added this to the 0.18.x milestone Jun 5, 2017
bsclifton added a commit that referenced this issue Jun 16, 2017
@bsclifton
Test all branches for tabsReducer => APP_TAB_CLOSED
c2b9aeb 
Fixes #9178

During this process, three issues were found/fixed:
- window was not being checked if truthy when closed
- tab close action NEXT was not being respected
- because getNextTabIdByIndex searches forward and backwards, the setting to first block was dead code (and was removed)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
automated-tests QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging a pull request may close this issue.

Add tests for tab reducer => APP_TAB_CLOSED brave/browser-laptop
1 participant
@bsclifton