This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add tests for tab reducer => APP_TAB_CLOSED #9179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
commented
May 31, 2017
| }) | ||
|
|
||
| it('does nothing if tabId is TAB_ID_NONE') | ||
| describe('when updating active tab', function () { | ||
| // TODO: test all values for TAB_CLOSE_ACTION |
There was a problem hiding this comment.
This is what's left; I'll get back to this soon
bsclifton
force-pushed
the
update-active-tab-test
branch
from
a33e1d1 to
8eb2068
Compare
Fixes #9178 During this process, three issues were found/fixed: - window was not being checked if truthy when closed - tab close action NEXT was not being respected - because getNextTabIdByIndex searches forward and backwards, the setting to first block was dead code (and was removed)
bsclifton
force-pushed
the
update-active-tab-test
branch
from
8eb2068 to
3443c48
Compare
|
@bridiver @bbondy @NejcZdovc ready for review! 😄 Because this resolves an issue that @alexwykoff found, I'm going to merge into 0.15.x BTW, this brings branch coverage for |
|
Has been up for ~5 days without review; it's only tests, so I'll go ahead and merge (please do review if you have time). Thanks! |
|
sorry, last time I looked it said wip |
|
maybe there should be a notification when it changes out of work in progress? |
|
@bridiver no worries; I just noticed now that I didn't ping you in this PR (or on Slack). I'll do that next time 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test all branches for tabsReducer => APP_TAB_CLOSED
Fixes #9178
During this process, three issues were found/fixed:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests