Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove smallButton #9232

Closed
luixxiul opened this issue Jun 3, 2017 · 1 comment
Closed

Remove smallButton #9232

luixxiul opened this issue Jun 3, 2017 · 1 comment
Assignees
@luixxiul
Labels
misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.18.x Release

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jun 3, 2017 •
edited
Loading

Test plan

#9236 (comment)

Describe the issue you encountered: Remove smallButton from button.less. Since (at least) a half year the classname has only been used on findbar.js. Refactoring findbar with Aphrodite, the classname can be removed from button.less.

Also please refer the discussion here: 615a6ec#commitcomment-20830663

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:
@luixxiul luixxiul added this to the 0.18.x milestone Jun 3, 2017
@luixxiul luixxiul self-assigned this Jun 3, 2017
This was referenced Jun 3, 2017
Closed
Merged
@luixxiul luixxiul mentioned this issue Jun 9, 2017
Closed
@luixxiul
Copy link
Contributor Author

luixxiul commented Jun 9, 2017

Added release-notes/include to let (potential) contributors on UI know about the change.

This was referenced Jul 24, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
This was referenced Jul 26, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Jul 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.18.x Release
Development

No branches or pull requests
3 participants
@luixxiul @srirambv @LaurenWags