This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Remove smallButton from button.less #9236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixxiul
commented
Jun 6, 2017
| <button data-l10n-id='done' className='browserButton whiteButton smallButton'{'\n'} | ||
| onClick={'{this.onRemoveBookmark}'} /> | ||
| </Code></Pre> | ||
|
|
||
| <BrowserButton primaryColor l10nId='primaryColor' onClick={this.onRemoveBookmark} /> | ||
| <Pre><Code> | ||
| <BrowserButton l10nId='cancel' onClick={'{this.onRemoveBookmark}'} /> |
There was a problem hiding this comment.
the bug here (it lacks primaryColor) is going to be fixed with https://github.com/brave/browser-laptop/pull/9239/files#diff-4f8a61660fd4d0a235614f82308c769eR273
5 tasks
|
I took advantage of this removal and included |
luixxiul
commented
Jun 7, 2017
The classname has only been used on findbar. Closes #9232 Addresses #9233 Auditors: Test Plan: 1. npm run test -- --grep='findBar' 2. Open the browser 3. Display find bar 4. Run manual test plan on https://github.com/brave/browser-laptop/wiki/Manual-Tests#find-on-page
cezaraugusto
approved these changes
Jun 9, 2017
This was referenced Jun 9, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classname has only been used on findbar.
Closes #9232
Addresses #9233
Auditors:
Test Plan:
about:stylesSmall Buttonis not therenotificationItembuttonsSubmitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests