Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor findbar with Aphrodite #9233

Closed
luixxiul opened this issue Jun 3, 2017 · 0 comments · Fixed by #11417
Closed

Refactor findbar with Aphrodite #9233

luixxiul opened this issue Jun 3, 2017 · 0 comments · Fixed by #11417
Assignees
@luixxiul
Labels
feature/findbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jun 3, 2017 •
edited
Loading

Test plan

#11417 (comment)

Describe the issue you encountered: Refactor findbar with Aphrodite.
@luixxiul luixxiul self-assigned this Jun 3, 2017
This was referenced Jun 3, 2017
Closed
Merged
Merged
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Sep 24, 2017
@luixxiul luixxiul mentioned this issue Sep 24, 2017
Closed
8 tasks
@ghost ghost removed the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Sep 26, 2017
@ghost ghost removed this from the 0.21.x (Nightly Channel) milestone Sep 26, 2017
@luixxiul luixxiul mentioned this issue Oct 10, 2017
Merged
8 tasks
@luixxiul luixxiul added this to the 0.21.x (Developer Channel) milestone Oct 14, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@syuan100
Refactor findbar with Aphrodite
35ef39a 
Closes brave#9233

- Apply BrowserButton to the close button
- Apply Textbox to the input element
- Add color styles to theme.js

Auditors:

Test Plan:
1. Run `npm run test -- --grep='findbar'`
2. Open facebook.com
3. Display find bar
4. Make sure the bar is displayed properly
This was referenced Dec 20, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/findbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Refactor findbar with Aphrodite
4 participants
@bbondy @luixxiul @srirambv @LaurenWags