This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Refactor findbar with Aphrodite #11417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11417 +/- ##
==========================================
+ Coverage 52.48% 52.49% +<.01%
==========================================
Files 268 268
Lines 25229 25231 +2
Branches 4026 4026
==========================================
+ Hits 13242 13244 +2
Misses 11987 11987
|
Closes #9233 - Apply BrowserButton to the close button - Apply Textbox to the input element - Add color styles to theme.js Auditors: Test Plan: 1. Run `npm run test -- --grep='findbar'` 2. Open facebook.com 3. Display find bar 4. Make sure the bar is displayed properly
luixxiul
commented
Oct 13, 2017
| disabled={this.props.numberOfMatches <= 0} | ||
| onClick={this.onFindPrev} | ||
| // See autofillAddressPanel.js | ||
| // Ref: https://github.com/brave/browser-laptop/pull/7164#discussion_r100586892 |
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| const React = require('react') | |||
| const Immutable = require('immutable') | |||
| const {StyleSheet, css} = require('aphrodite') | |||
| const {StyleSheet, css} = require('aphrodite/no-important') | |||
cezaraugusto
approved these changes
Oct 13, 2017
cezaraugusto
added a commit
that referenced
this pull request
Oct 13, 2017
Refactor findbar with Aphrodite
|
0.21.x a950f88 |
please wait for another big update... :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9233
Auditors: @cezaraugusto
Test Plan:
npm run test -- --grep='findbar'Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests