Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Merge span.findButton with .closeButton on findbar.less #9235

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Merge span.findButton with .closeButton on findbar.less #9235

merged 1 commit into from
Jun 5, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jun 3, 2017 •
edited
Loading

Close #9234
Addresses #9233

Auditors:

Test Plan:

  1. Open find bar
  2. Close it by clicking the close button

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Merge span.findButton with .closeButton on findbar.less
9e7ee8f 
Close #9234
Addresses #9233

Auditors:

Test Plan:
1. Open find bar
2. Close it by clicking the close button
@luixxiul luixxiul added this to the 0.18.x milestone Jun 3, 2017
@luixxiul luixxiul self-assigned this Jun 3, 2017
@luixxiul luixxiul requested a review from cezaraugusto June 3, 2017 15:09
cezaraugusto
cezaraugusto reviewed Jun 5, 2017
View reviewed changes
less/findbar.less
opacity: 0.5;
transform: rotate(45deg);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

cezaraugusto
cezaraugusto approved these changes Jun 5, 2017
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 315702e into brave:master Jun 5, 2017
@luixxiul luixxiul mentioned this pull request Jun 5, 2017
Closed
@luixxiul luixxiul deleted the fix-findbarCloseButton branch June 6, 2017 02:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

Assignees

@luixxiul luixxiul

Labels
feature/findbar misc/button
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging this pull request may close these issues.

Merge span.findButton with .closeButton on findbar.less
2 participants
@luixxiul @cezaraugusto