Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Merge span.findButton with .closeButton on findbar.less #9235

Merged
merged 1 commit into from
Jun 5, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge span.findButton with .closeButton on findbar.less
Close #9234
Addresses #9233

Auditors:

Test Plan:
1. Open find bar
2. Close it by clicking the close button
  • Loading branch information
Suguru Hirahara committed Jun 3, 2017
commit 9e7ee8f9ac386aa46eb5403516b7a2d679de277f
2 changes: 1 addition & 1 deletion app/renderer/components/main/findbar.js
Original file line number Diff line number Diff line change
@@ -252,7 +252,7 @@ class FindBar extends ImmutableComponent {
onClick={this.onCaseSensitivityChange} />
<label htmlFor='caseSensitivityCheckbox' data-l10n-id='caseSensitivity' style={findBarTextStyle} />
</div>
<span className='findButton closeButton'
<span className='closeButton'
style={findBarTextStyle}
onClick={this.props.onFindHide}>+</span>
</div>
16 changes: 4 additions & 12 deletions less/findbar.less
Original file line number Diff line number Diff line change
@@ -30,13 +30,13 @@
color: @mediumGray;
}

span.findButton {
.closeButton {
border: 1px solid transparent;
color: @gray;
cursor: default;
border: 1px solid transparent;
font-size: 18px;
margin: 0 2px;
font-size: 22px;
opacity: 0.5;
transform: rotate(45deg);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice


&:not([disabled]):hover {
opacity: 1;
@@ -47,14 +47,6 @@
}
}

.closeButton {
color: white;
font-size: 22px;
margin-right: 0;
opacity: 0.5;
transform: rotate(45deg);
}

.searchContainer {
display: flex;
align-items: center;