Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

temporarily disable the "Fund with debit/credit card" button until we have clarity on miner fees. #9327

Closed
mrose17 opened this issue Jun 7, 2017 · 3 comments
Closed

temporarily disable the "Fund with debit/credit card" button until we have clarity on miner fees. #9327

mrose17 opened this issue Jun 7, 2017 · 3 comments
Assignees
@bsclifton
Labels
copy/content/text feature/rewards QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.16.x (Frozen, o...

Comments

@mrose17
Copy link
Member

mrose17 commented Jun 7, 2017 •
edited by bsclifton
Loading

Test plan

See #9331

Original issue description

0_720_480
1_720_480

  1. disable the "Fund with debit/credit card" button
  2. replace the "Transfer may take up to 40 minutes" text with text/link from @bradleyrichter

  • Did you search for similar issues before submitting this one? no.

  • Describe the issue you encountered: res ipsa loquitur

  • Platform (Win7, 8, 10? macOS? Linux distro?): all

  • Brave Version (revision SHA): n/a

  • Steps to reproduce: res ipsa loquitur

  • Actual result: res ipsa loquitur

  • Expected result: res ipsa loquitur

  • Will the steps above reproduce in a fresh profile? yes

  • Is this an issue in the currently released version? yes

  • Can this issue be consistently reproduced? yes

  • Extra QA steps: none

  • Screenshot if needed: see below

  • Any related issues: none
@bradleyrichter
Copy link
Contributor

bradleyrichter commented Jun 7, 2017 •
edited
Loading

mockup:

image

@bradleyrichter
Copy link
Contributor

text:

Card funding is temporarily unavailable.
We apologize for the inconvenience. Learn more...

@luixxiul
Copy link
Contributor

luixxiul commented Jun 8, 2017

Let's use browserButton on https://github.com/brave/browser-laptop/blob/master/app/renderer/components/common/browserButton.js#L31 for the button.

@bsclifton bsclifton mentioned this issue Jun 8, 2017
Merged
8 tasks
bsclifton added a commit that referenced this issue Jun 8, 2017
@bsclifton
Disables funding with debit/credit card. Only affects Coinbase (ex: c…
2a2aaa1 
…ustomers in USA)

Fixes #9327

Auditors: @cezaraugusto, @NejcZdovc

Test Plan:
1. Be on an IP that is geo-located in the USA (via VPN or physically being in USA)
2. Go to Preferences > Payments
3. Click "Add funds"
4. "Fund with debit/credit" button should be disabled; appropriate messaging should be displayed (see issue)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
copy/content/text feature/rewards QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.16.x (Frozen, only critical adds fr...
Development

No branches or pull requests
5 participants
@mrose17 @luixxiul @bsclifton @bradleyrichter @srirambv