This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Disables funding with debit/credit card. Only affects Coinbase #9331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note: this change was done in a way that we can easily enable/disable the UI in case of a service outage (UI looks at a single boolean for enabled / disabled) |
…ustomers in USA) Fixes #9327 Auditors: @cezaraugusto, @NejcZdovc Test Plan: 1. Be on an IP that is geo-located in the USA (via VPN or physically being in USA) 2. Go to Preferences > Payments 3. Click "Add funds" 4. "Fund with debit/credit" button should be disabled; appropriate messaging should be displayed (see issue)
bsclifton
force-pushed
the
disable-fund-with-cc
branch
from
2adba93 to
2a2aaa1
Compare
|
I have some ideas to polish the button. I'll give a try with another PR. |
|
Thanks for taking this clifton, merging. |
bbondy
added a commit
that referenced
this pull request
Jun 8, 2017
Disables funding with debit/credit card. Only affects Coinbase
bbondy
added a commit
that referenced
this pull request
Jun 8, 2017
Disables funding with debit/credit card. Only affects Coinbase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
Description
Disables funding with debit/credit card. Only affects Coinbase (ex: customers in USA)
Fixes #9327
Auditors: @cezaraugusto, @NejcZdovc
Submitter Checklist:
git rebase -ito squash commits (if needed).Reviewer Checklist:
Tests