Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

move most extension registration from muon into browser-laptop #9584

Closed
kevinlawler opened this issue Jun 19, 2017 · 3 comments
Closed

move most extension registration from muon into browser-laptop #9584

kevinlawler opened this issue Jun 19, 2017 · 3 comments
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.18.x Release

Comments

@kevinlawler
Copy link
Contributor

kevinlawler commented Jun 19, 2017 •
edited by luixxiul
Loading

Test plan

See #9585
kevinlawler added a commit that referenced this issue Jun 19, 2017
@kevinlawler
move muon extension constants into js/constants
79cd681 
#9584

Auditors:
bridriver

Test Plan:
Verify extensions+Widevine all load in Release copy with clean brave-development dir
@kevinlawler kevinlawler mentioned this issue Jun 19, 2017
Merged
8 tasks
kevinlawler added a commit to brave/muon that referenced this issue Jun 19, 2017
@kevinlawler
muon side of extension constant porting to browser-laptop
01a0b43 
brave/browser-laptop#9584

Merge after merging
brave/browser-laptop#9585
(or errors will ensue until both are merged)
@kevinlawler kevinlawler mentioned this issue Jun 19, 2017
Merged
bridiver pushed a commit to brave/muon that referenced this issue Jun 20, 2017
@kevinlawler @bridiver
muon side of extension constant porting to browser-laptop
4cbc075 
brave/browser-laptop#9584

Merge after merging
brave/browser-laptop#9585
(or errors will ensue until both are merged)
@bsclifton bsclifton added this to the 0.19.x (Nightly Channel) milestone Jun 20, 2017
@bsclifton
Copy link
Member

@kevinlawler was this issue supposed to be closed after #9585? or is there more to do?

@kevinlawler
Copy link
Contributor Author

Now that #9585 and brave/muon#223 have both landed, we can close this issue. I should've noted this originally...

bbondy pushed a commit that referenced this issue Jul 4, 2017
@kevinlawler @bbondy
move muon extension constants into js/constants
cb57cac 
#9584

Auditors:
bridriver

Test Plan:
Verify extensions+Widevine all load in Release copy with clean brave-development dir
@bbondy bbondy modified the milestones: 0.18.x (Beta Channel), 0.19.x (Developer Channel) Jul 4, 2017
bridiver pushed a commit to brave/muon that referenced this issue Jul 9, 2017
@kevinlawler @bridiver
muon side of extension constant porting to browser-laptop
a07c5be 
brave/browser-laptop#9584

Merge after merging
brave/browser-laptop#9585
(or errors will ensue until both are merged)
bsclifton pushed a commit that referenced this issue Jul 11, 2017
@kevinlawler @bsclifton
move muon extension constants into js/constants
4010109 
#9584

Auditors:
bridriver

Test Plan:
Verify extensions+Widevine all load in Release copy with clean brave-development dir
@bsclifton
Copy link
Member

manually cherry picked to 0.18.x with 4010109. Required since we're using a newer Muon (4.3.1)

This was referenced Jul 24, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
This was referenced Jul 26, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Jul 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.18.x Release
Development

No branches or pull requests
6 participants
@kevinlawler @bbondy @luixxiul @bsclifton @srirambv @LaurenWags