This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
move muon extension constants into js/constants #9585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#9584 Auditors: bridriver Test Plan: Verify extensions+Widevine all load in Release copy with clean brave-development dir
kevinlawler
added a commit
to brave/muon
that referenced
this pull request
Jun 19, 2017
brave/browser-laptop#9584 Merge after merging brave/browser-laptop#9585 (or errors will ensue until both are merged)
bridiver
approved these changes
Jun 20, 2017
bridiver
pushed a commit
to brave/muon
that referenced
this pull request
Jun 20, 2017
brave/browser-laptop#9584 Merge after merging brave/browser-laptop#9585 (or errors will ensue until both are merged)
|
This is beautiful! Great job, Kevin 😄 |
bridiver
pushed a commit
to brave/muon
that referenced
this pull request
Jul 9, 2017
brave/browser-laptop#9584 Merge after merging brave/browser-laptop#9585 (or errors will ensue until both are merged)
|
Pulling back to 0.18.x- the Muon changes require this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9584
Merge this prior to merging the Muon side (brave/muon#223) or problems will result until both are merged.
Auditors:
@bridiver
Test Plan:
Verify extensions+Widevine all load in Release copy with clean brave-development dir
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests