-
Notifications
You must be signed in to change notification settings - Fork 974
Rename Yes/No buttons to Allow/Deny for easier understanding #9750
Comments
This is a nice polishing step IMO WDYT, @bradleyrichter @alexwykoff ? |
I agree. But I would like to see a table of all alert messages and refine them all in one go if possible. @cezaraugusto @bsclifton Can we generate this table? Or is it a matter of cherry picking strings? |
only way is manually I think, I'll take care of that |
+1 from me. |
Auditors: @luixxiul, @srirambv close brave#9750
Reopening issue based on #10180 (comment) |
@cezaraugusto @bradleyrichter Should the order be Allow/Deny/Never remember or Deny/Allow/Never Remember to keep consitency |
deferring to @bradleyrichter |
"Would you like Brave to save this password" = No/Yes "Allow Brave to save this password" = Deny/Allow So I think our strings are currently phrased for No/Yes. Also, we need to follow the style for "Continue-Yes on the Right side". This is the internet standard and only Windows still uses the inverse approach. Our new approach should follow this mockup: |
Test plan
#10180 (comment)
Did you search for similar issues before submitting this one
Yes?
Describe the issue you encountered:
Platform (Win7, 8, 10? macOS? Linux distro?):
All
Brave Version (revision SHA):
0.16.9
Screenshot if needed:
Any related issues:
https://community.brave.com/t/requests-re-block-autoplay-controls/4324
The text was updated successfully, but these errors were encountered: