replace yes/no to allow/deny for notifcation bar

[cezaraugusto]

---

dear reviewer, do not land before #10178. thanks!

---

/cc @bradleyrichter pls see screenshots below. maybe we want to change strings for some questions too?

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.

Auditors: @luixxiul, @srirambv
close #9750

Test Plan:

notifications bar test should pass

npm run test -- --grep="notificationBar permissions"

Autoplay:

got to prefs->security and set autoplay to "always ask"
go to https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_video_autoplay

Restart:

go to prefs->general and try to switch languages.

Autofill:

go to prefs->security and set pw manager to built-in
go to any page that you have to write things so Brave can ask to save that for you

Reviewer Checklist:

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[darkdh]

lgtm thanks for the #10178 reminder

[srirambv]

Manually tested. Looks good to go

[bsclifton]

@cezaraugusto can you rebase? then we're ready for merge 😄

[cezaraugusto]

ok rebased waiting travis

[codecov-io]

Codecov Report

Merging #10180 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10180      +/-   ##
==========================================
- Coverage   52.95%   52.94%   -0.01%     
==========================================
  Files         228      228              
  Lines       20308    20308              
  Branches     3254     3254              
==========================================
- Hits        10754    10753       -1     
- Misses       9554     9555       +1

Flag	Coverage Δ
#unittest	52.94% <ø> (-0.01%)	⬇️

Impacted Files	Coverage Δ
app/browser/reducers/autoplayReducer.js	97.29% <ø> (ø)	⬆️
app/renderer/lib/extensionsUtil.js	58.88% <0%> (-1.56%)	⬇️
js/about/preferences.js	42.79% <0%> (+0.11%)	⬆️

[luixxiul]

isn't this ready to be merged? :-)

[srirambv]

Somethings broken Seeing Yes/No for browser restart

[cezaraugusto]

@srirambv what's wrong? should it be no/yes instead?

[cezaraugusto]

actually for restart notification it should be yes/no (not sure about the order) but not allow/deny

[bradleyrichter]

Should be No/Yes.

…

On Dec 22, 2017, at 2:43 PM, Cezar Augusto ***@***.***> wrote: actually for restart notification it should be yes/no (not sure about the order) but not allow/deny — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10180 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AM4jqupB2Cb1RUxAN--pThWXrY-38k5Mks5tDDCagaJpZM4Ol7-S>.