Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave should default download path to the downloads folder #9822

Closed
Jacalz opened this issue Jul 1, 2017 · 5 comments · Fixed by #11994
Closed

Brave should default download path to the downloads folder #9822

Jacalz opened this issue Jul 1, 2017 · 5 comments · Fixed by #11994

Comments

@Jacalz
Copy link
Contributor

Jacalz commented Jul 1, 2017

Test plan

#11994 (comment)


I think that brave should default the download path to the downloads folder so it automatically downloads files to that folder.

@bsclifton
Copy link
Member

Is this not already the case? I know it may show as empty on fresh install, but it should be defaulting to the default download path when the dialog comes up

cc: @LaurenWags, @srirambv, @luixxiul

@Jacalz
Copy link
Contributor Author

Jacalz commented Aug 9, 2017

I mean without bringing up the dialog, like when you choose where to download to and you disable the option to always ask where to save files 😉

@srirambv
Copy link
Collaborator

srirambv commented Aug 9, 2017

I had brought this question before but guess it was lost in conversation 😅 . I think if the download path is not explicitly set then we may hide the file save dialog but again it will be an extra step for users to again change the download path. However if the default path is changed, it should add the path when it changes (which is currently missing). Also have a look at #9010

I feel the current behavior is good as it gives the user an option to change the path each time and not go into setting each time. I'd say keep the current behavior rather than removing the dialog and making users go to preferences each time they want to change the path.

@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
@darkdh darkdh self-assigned this Nov 16, 2017
darkdh added a commit to brave/muon that referenced this issue Nov 16, 2017
darkdh added a commit that referenced this issue Nov 16, 2017
fix #9822
requires brave/muon#390

Auditors: @bridiver, @bbondy, @bsclifton

Test Plan:
1. Open Brave with fresh profile
2. Go to about:preferences#general
3. It should show default download path instead of empty
darkdh added a commit to brave/muon that referenced this issue Nov 16, 2017
darkdh added a commit that referenced this issue Nov 16, 2017
fix #9822
requires brave/muon#390

Auditors: @bridiver, @bbondy, @bsclifton

Test Plan:
1. Open Brave with fresh profile
2. Go to about:preferences#general
3. It should show default download path instead of empty
darkdh added a commit that referenced this issue Nov 29, 2017
fix #9822

Auditors: @bridiver, @bbondy, @bsclifton

Test Plan:
1. Open Brave with fresh profile
2. Go to about:preferences#general
3. It should show default download path instead of empty
darkdh added a commit that referenced this issue Dec 4, 2017
fix #9822

Auditors: @bridiver, @bbondy, @bsclifton

Test Plan:
a. Manual Test
1. Open Brave with fresh profile
2. Go to about:preferences#general
3. It should show default download path instead of empty

b. unit test
@bsclifton bsclifton modified the milestones: Triage Backlog, 0.21.x (Developer Channel) Dec 19, 2017
darkdh added a commit that referenced this issue Dec 19, 2017
fix #9822

Auditors: @bridiver, @bbondy, @bsclifton

Test Plan:
a. Manual Test
1. Open Brave with fresh profile
2. Go to about:preferences#general
3. It should show default download path instead of empty

b. unit test
@bsclifton bsclifton modified the milestones: 0.22.x (Developer Channel), 0.21.x w/ Chromium 65 (Beta Channel) Mar 1, 2018
@bsclifton
Copy link
Member

Moving to 0.22.x; we're going to have 0.21.x-C65 only contain the Chromium upgrade 😄 👍

@LaurenWags
Copy link
Member

LaurenWags commented Mar 22, 2018

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.