This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Set initial default download path #390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Nov 16, 2017
fix #9822 requires brave/muon#390 Auditors: @bridiver, @bbondy, @bsclifton Test Plan: 1. Open Brave with fresh profile 2. Go to about:preferences#general 3. It should show default download path instead of empty
8 tasks
partial resolves brave/browser-laptop#9822 requires brave/browser-laptop#11994 Auditors: @bridiver, @bsclifton, @bbondy
darkdh
force-pushed
the
browser-laptop-issue-9822
branch
from
ce14894 to
96c98a6
Compare
darkdh
added a commit
to brave/browser-laptop
that referenced
this pull request
Nov 16, 2017
fix #9822 requires brave/muon#390 Auditors: @bridiver, @bbondy, @bsclifton Test Plan: 1. Open Brave with fresh profile 2. Go to about:preferences#general 3. It should show default download path instead of empty
bridiver
reviewed
Nov 29, 2017
| @@ -699,6 +700,12 @@ void App::SetPath(mate::Arguments* args, | |||
| args->ThrowError("Failed to set path"); | |||
| } | |||
|
|
|||
| base::FilePath App::GetInitialDownloadPath() { | |||
There was a problem hiding this comment.
isn't this already accessible with getPath('downloads')?
There was a problem hiding this comment.
yeah, you are right!!! I'm going to close this PR and update PR of browser-laptop
|
per #390 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial resolves brave/browser-laptop#9822
requires brave/browser-laptop#11994
Auditors: @bridiver, @bsclifton, @bbondy