Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

keyboard shortcut for undo last closed frame with no last closed frame causes an error #9948

Closed
bridiver opened this issue Jul 11, 2017 · 0 comments · Fixed by #9949
Closed

keyboard shortcut for undo last closed frame with no last closed frame causes an error #9948

bridiver opened this issue Jul 11, 2017 · 0 comments · Fixed by #9949
Assignees
@bridiver
Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.18.x Release

Comments

@bridiver
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    keyboard shortcut for undo last closed frame causes an error if there is no last closed frame

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    03ae74b

  • Steps to reproduce:

    1. Fresh profile
    2. cmd-shift T

  • Actual result:
    Stack trace on command line

  • Expected result:
    No stack trace

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes
@bridiver bridiver self-assigned this Jul 11, 2017
@bridiver bridiver added the bug label Jul 11, 2017
@bridiver bridiver added this to the 0.18.x (Beta Channel) milestone Jul 11, 2017
bridiver added a commit that referenced this issue Jul 11, 2017
@bridiver
don’t return from reducer without state
c1277ec 
fix #9948
@bridiver bridiver mentioned this issue Jul 11, 2017
Merged
8 tasks
This was referenced Jul 24, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
This was referenced Jul 26, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Jul 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bridiver bridiver

Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging a pull request may close this issue.

don’t return from reducer without state brave/browser-laptop
5 participants
@bridiver @luixxiul @srirambv @Jacalz @LaurenWags