don’t return from reducer without state #9949

bridiver · 2017-07-11T01:48:31Z

fix #9948

Submitter Checklist:

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).
Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

Adequate test coverage exists to prevent regressions
Tests should be independent and work correctly when run individually or as a suite ref
New files have MPL2 license header

fix #9948

bsclifton

Change LGTM 😄 👍

@bridiver

…rned Statement coverage from 0% to 56.13% Branch coverage from 0% to 41.75% Function coverage from 0% to 22.92% Line coverage from 0% to 56.4% Auditors: @bridiver Test Plan: `npm run unittest -- --grep="menu reducer unit tests"`

bsclifton · 2017-07-13T06:34:18Z

@bridiver I added unit tests for app/browser/menu 😄

Statement coverage from 0% to 56.13%
Branch coverage from 0% to 41.75%
Function coverage from 0% to 22.92%
Line coverage from 0% to 56.4%

Notice that I adjusted some code to check for falsey conditions to prevent crash if the field is missing.

don’t return from reducer without state

c1277ec

fix #9948

bridiver added the bug label Jul 11, 2017

bridiver added this to the 0.18.x (Beta Channel) milestone Jul 11, 2017

bridiver self-assigned this Jul 11, 2017

bridiver requested review from ayumi and bbondy July 11, 2017 01:48

bsclifton approved these changes Jul 12, 2017

View reviewed changes

bridiver merged commit d3f96bb into master Jul 13, 2017

bsclifton deleted the issue-9948 branch July 14, 2017 05:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

don’t return from reducer without state #9949

don’t return from reducer without state #9949

bridiver commented Jul 11, 2017 •

edited by bsclifton

Loading

bsclifton left a comment

bsclifton commented Jul 13, 2017 •

edited

Loading

don’t return from reducer without state #9949

don’t return from reducer without state #9949

Conversation

bridiver commented Jul 11, 2017 • edited by bsclifton Loading

bsclifton left a comment

Choose a reason for hiding this comment

bsclifton commented Jul 13, 2017 • edited Loading

bridiver commented Jul 11, 2017 •

edited by bsclifton

Loading

bsclifton commented Jul 13, 2017 •

edited

Loading