Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Reorganize rel='noopener' #10424

Merged
merged 1 commit into from
Sep 4, 2017
Merged

Reorganize rel='noopener' #10424

merged 1 commit into from
Sep 4, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Aug 11, 2017

Follow-up to #10290

Also:

Auditors:

Test Plan:

  1. Search your repo for target='_blank'
  2. Make sure external anchor links with target='_blank' have rel='noopener'

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@luixxiul luixxiul added polish Nice to have — usually related to front-end/visual tasks. QA/no-qa-needed security labels Aug 11, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 11, 2017
@luixxiul luixxiul self-assigned this Aug 11, 2017
@luixxiul luixxiul requested a review from bsclifton August 11, 2017 07:36
@codecov-io
Copy link

codecov-io commented Aug 11, 2017

Codecov Report

Merging #10424 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #10424      +/-   ##
==========================================
- Coverage   54.44%   54.43%   -0.02%     
==========================================
  Files         246      246              
  Lines       21365    21364       -1     
  Branches     3320     3320              
==========================================
- Hits        11633    11629       -4     
- Misses       9732     9735       +3
Flag Coverage Δ
#unittest 54.43% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
...r/components/preferences/payment/enabledContent.js 93.22% <ø> (-0.23%) ⬇️
...pp/renderer/components/preferences/helpfulHints.js 100% <ø> (ø) ⬆️
app/renderer/components/preferences/paymentsTab.js 83.51% <ø> (ø) ⬆️
js/about/newTabComponents/footerInfo.js 60% <ø> (ø) ⬆️
...components/preferences/payment/bitcoinDashboard.js 21.46% <0%> (-0.38%) ⬇️

Follow-up to #10290

Also:
- Add rel='noopener' to brave.com (as the site also may be hacked, which of course should not happen)
- Fix a typo
- Always rel='noopener' first, target='_blank' second on the same line (to make it easy to search it with regex)

Auditors:

Test Plan:
1. Search your repo for target='_blank'
2. Make sure external anchor links with target='_blank' have rel='noopener'
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes- great find with the typo 😄

@bsclifton bsclifton merged commit 51d6eb2 into brave:master Sep 4, 2017
@luixxiul luixxiul deleted the followup-noopener branch September 5, 2017 01:29
@luixxiul
Copy link
Contributor Author

luixxiul commented Sep 5, 2017

@bsclifton thanks for reviewing :-)

@bbondy bbondy removed this from the 0.21.x (Developer Channel) milestone Oct 25, 2017
@luixxiul luixxiul added this to the 0.20.x (Beta Channel) milestone Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
polish Nice to have — usually related to front-end/visual tasks. QA/no-qa-needed security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants