Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Reorganize rel='noopener' #10424

Merged
merged 1 commit into from
Sep 4, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/renderer/components/preferences/helpfulHints.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ class HelpfulHints extends ImmutableComponent {
<div className={css(styles.hints, styles.white)} data-l10n-id={`hint${this.props.hintNumber}`} />
<div className={css(styles.helpfulHintsBottom)}>
<a className={css(styles.white)}
target='_blank' href='https://community.brave.com/'
data-l10n-id='submitFeedback' />
href='https://community.brave.com/'
data-l10n-id='submitFeedback'
rel='noopener' target='_blank' />
</div>
</div>
}
Expand Down
26 changes: 13 additions & 13 deletions app/renderer/components/preferences/payment/bitcoinDashboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ class BitcoinDashboard extends ImmutableComponent {
<div data-l10n-id='fundingDisabled1' />
<div>
<span data-l10n-id='fundingDisabled2' />&nbsp;
<a href='https://community.brave.com/c/payments' target='_blank' data-l10n-id='fundingDisabled3' />
<a href='https://community.brave.com/c/payments' data-l10n-id='fundingDisabled3' rel='noopener' target='_blank' />
</div>
</div>
: <div className={css(
Expand Down Expand Up @@ -194,7 +194,7 @@ class BitcoinDashboard extends ImmutableComponent {
</div>
</div>
<div className={css(styles.panel__divider, styles.panel__divider_right)}>
<a target='_blank' rel='noopener' href={url}>
<a href={url} rel='noopener' target='_blank'>
<BrowserButton
primaryColor
panelItem
Expand All @@ -219,7 +219,7 @@ class BitcoinDashboard extends ImmutableComponent {
</div>
</div>
<div className={css(styles.panel__divider, styles.panel__divider_right)}>
<a target='_blank' rel='noopener' href='https://www.buybitcoinworldwide.com/'>
<a href='https://www.buybitcoinworldwide.com/' rel='noopener' target='_blank'>
<BrowserButton
primaryColor
panelItem
Expand Down Expand Up @@ -325,19 +325,19 @@ class BitcoinDashboard extends ImmutableComponent {
if (coinbaseCountries.indexOf(this.props.ledgerData.get('countryCode')) > -1) {
return <section className={css(styles.modalOverlay__qrcodeOverlay__footerWrapper__footer)}>
<div className={css(styles.coinbaseLogo)} />
<a rel='noopener' target='_blank'
className={css(
styles.modalOverlay__qrcodeOverlay__footerWrapper__footer__qrcodeLogo,
styles.modalOverlay__qrcodeOverlay__footerWrapper__footer__appstoreLogo
)}
<a className={css(
styles.modalOverlay__qrcodeOverlay__footerWrapper__footer__qrcodeLogo,
styles.modalOverlay__qrcodeOverlay__footerWrapper__footer__appstoreLogo
)}
href='https://itunes.apple.com/us/app/coinbase-bitcoin-wallet/id886427730?mt=8'
rel='noopener' target='_blank'
/>
<a rel='noopener' target='_blank'
className={css(
styles.modalOverlay__qrcodeOverlay__footerWrapper__footer__qrcodeLogo,
styles.modalOverlay__qrcodeOverlay__footerWrapper__footer__playstoreLogo
)}
<a className={css(
styles.modalOverlay__qrcodeOverlay__footerWrapper__footer__qrcodeLogo,
styles.modalOverlay__qrcodeOverlay__footerWrapper__footer__playstoreLogo
)}
href='https://play.google.com/store/apps/details?id=com.coinbase.android'
rel='noopener' target='_blank'
/>
</section>
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class EnabledContent extends ImmutableComponent {

return <section className={css(styles.balance)}>
<FormTextbox data-test-id='fundsAmount' readOnly value={btcToCurrencyString(value, ledgerData)} />
<a className={css(styles.iconLink)} href='https://brave.com/Payments_FAQ.html' target='_blank'>
<a className={css(styles.iconLink)} href='https://brave.com/Payments_FAQ.html' rel='noopener' target='_blank'>
<span className={cx({
fa: true,
'fa-question-circle': true,
Expand Down
2 changes: 1 addition & 1 deletion app/renderer/components/preferences/paymentsTab.js
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,8 @@ class PaymentsTab extends ImmutableComponent {
[css(styles.autoSuggestSwitch__moreInfoBtnSuggest)]: true
})}
href='https://brave.com/Payments_FAQ.html'
target='_blank'
data-l10n-id='paymentsFAQLink'
rel='noopener' target='_blank'
/>
</div>
{
Expand Down
2 changes: 1 addition & 1 deletion js/about/about.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class AboutAbout extends ImmutableComponent {
{
aboutUrls.keySeq().sort().filter((aboutSourceUrl) => isNavigatableAboutPage(aboutSourceUrl)).map((aboutSourceUrl) =>
<li>
<a href={aboutUrls.get(aboutSourceUrl)} target='_blank'>
<a href={aboutUrls.get(aboutSourceUrl)} rel='noopener' target='_blank'>
{aboutSourceUrl}
</a>
</li>)
Expand Down
8 changes: 6 additions & 2 deletions js/about/brave.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,11 @@ class AboutBrave extends React.Component {
<div>
<span data-l10n-id='relNotesInfo1' />
&nbsp;
<a className={css(commonStyles.linkText)} href={`https://github.com/brave/browser-laptop/releases/tag/v${this.state.versionInformation.get('Brave')}dev`} rel='noopener' target='_blank' data-l10n-id='relNotesInfo2' />
<a className={css(commonStyles.linkText)}
href={`https://github.com/brave/browser-laptop/releases/tag/v${this.state.versionInformation.get('Brave')}dev`}
data-l10n-id='relNotesInfo2'
rel='noopener' target='_blank'
/>
&nbsp;
<span data-l10n-id='relNotesInfo3' />
</div>
Expand All @@ -83,7 +87,7 @@ class AboutBrave extends React.Component {
},
{
html: name === 'rev'
? <a rel='noopener' target='_blank' className={css(commonStyles.linkText)} href={`https://github.com/brave/browser-laptop/commit/${version}`}>{(version && version.substring(0, 7)) || ''}</a>
? <a className={css(commonStyles.linkText)} href={`https://github.com/brave/browser-laptop/commit/${version}`} rel='noopener' target='_blank'>{(version && version.substring(0, 7)) || ''}</a>
: version,
value: version
}
Expand Down
2 changes: 1 addition & 1 deletion js/about/contributionStatement.js
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ class ContributionStatement extends React.Component {
transactions.map(function (tx) {
return (
<li>
<a className={css(styles.list__anchor)} href={aboutContributionsUrl + '#' + tx.get('viewingId')} target='_blank'>
<a className={css(styles.list__anchor)} href={aboutContributionsUrl + '#' + tx.get('viewingId')} rel='noopener' target='_blank'>
{this.receiptFileName(tx)}
</a>
</li>
Expand Down
2 changes: 1 addition & 1 deletion js/about/newTabComponents/footerInfo.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class FooterInfo extends ImmutableComponent {
this.props.backgroundImage && this.props.backgroundImage.name
? <div>
<div className='copyrightCredits'>
<span className='photoBy' data-l10n-id='photoBy' /> <a className='copyrightOwner' href={this.props.backgroundImage.link} rel='noopner' target='_blank'>{this.props.backgroundImage.author}</a>
<span className='photoBy' data-l10n-id='photoBy' /> <a className='copyrightOwner' href={this.props.backgroundImage.link} rel='noopener' target='_blank'>{this.props.backgroundImage.author}</a>
</div>
<span className='photoName'>{this.props.backgroundImage.name}</span>
</div>
Expand Down
3 changes: 1 addition & 2 deletions js/webtorrent/components/torrentViewer.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ class TorrentViewer extends React.Component {
})}
data-l10n-id='poweredByWebTorrent'
href='https://webtorrent.io'
rel='noopener'
target='_blank'
rel='noopener' target='_blank'
/>
)
} else {
Expand Down