This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Update "Our Partners" side bar on disabledContent.js to reflect BAT i… #11244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #11009 Auditors: Test Plan:
- siteSettingsReducerTest (should be 100% coverage now) - add more tests for ledgerUtil (btcToCurrencyString, etc) Auditors: @NejcZdovc
Auditors: @NejcZdovc Test Plan:
…ntegration Closes #11242 Auditors: @cezaraugusto Test Plan: 1. Open about:preferences#payments 2. Make sure 'Brave Bitcoin Wallets' is replaced with 'Brave BAT Wallets' 3. Make sure the uphold company logo is displayed
NejcZdovc
requested review from
NejcZdovc
and removed request for
bradleyrichter
NejcZdovc
force-pushed
the
bat-integration
branch
from
8ed4680 to
2a0eedd
Compare
8 tasks
NejcZdovc
force-pushed
the
bat-integration
branch
15 times, most recently
from
32230b0 to
8781761
Compare
|
I merged it directly into the master d4468fd |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntegration
Closes #11242 (when #11231 is merged to
master)Auditors: @cezaraugusto
Test Plan:
npm run unittestSubmitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests