-
Notifications
You must be signed in to change notification settings - Fork 975
Fixes edit flow for bookmarks and folders #12589
Conversation
Resolves brave#12484 Auditors: Test Plan:
Codecov Report
@@ Coverage Diff @@
## master #12589 +/- ##
==========================================
+ Coverage 56.05% 56.05% +<.01%
==========================================
Files 278 278
Lines 27065 27075 +10
Branches 4381 4384 +3
==========================================
+ Hits 15172 15178 +6
- Misses 11893 11897 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with steps from PR and original steps from logged issue.
Additional test done:
Have folder on Bookmark Toolbar.
Open Bookmarks Manager.
Right click on folder under Bookmarks Toolbar, select Edit Folder.
Update location to be Other Bookmarks, save.
Folder no longer displays on Bookmarks Toolbar and appropriately displays under Other Bookmarks.
|
||
if (oldFolder.isEmpty()) { | ||
if (oldFolder == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this condition ever get hit (null/undefined being passed in)? The caller isn't checking for null/undefined before calling .isEmpty()
on the param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Fixes edit flow for bookmarks and folders
Fixes edit flow for bookmarks and folders
Submitter Checklist:
git rebase -i
to squash commits (if needed).Resolves #12484
Auditors:
Test Plan:
Reviewer Checklist:
Tests