This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
Fixes upgrade of bookmark/folder width #12768
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves brave#9517 Resolves brave#9939 Auditors: Test Plan:
Codecov Report
@@ Coverage Diff @@
## master #12768 +/- ##
==========================================
- Coverage 56.13% 56.1% -0.03%
==========================================
Files 279 279
Lines 27309 27316 +7
Branches 4442 4443 +1
==========================================
- Hits 15329 15327 -2
- Misses 11980 11989 +9
|
bsclifton
force-pushed
the
hotfix/#9517-update
branch
from
January 22, 2018 19:09
956108e
to
05cd2c3
Compare
bsclifton
suggested changes
Jan 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See feedback
Auditors: Test Plan:
NejcZdovc
force-pushed
the
hotfix/#9517-update
branch
from
January 25, 2018 09:58
05cd2c3
to
c830371
Compare
bsclifton
approved these changes
Jan 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With your latest updates, this works great 😄 👍 Thanks for fixing the edge case
bsclifton
added a commit
that referenced
this pull request
Jan 25, 2018
Fixes upgrade of bookmark/folder width
bsclifton
added a commit
that referenced
this pull request
Jan 25, 2018
Fixes upgrade of bookmark/folder width
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Resolves #9517
Resolves #9939
Auditors:
Test Plan:
Reviewer Checklist:
Tests