Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes upgrade of bookmark/folder width #12768

Merged
merged 2 commits into from
Jan 25, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 22, 2018

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Resolves #9517
Resolves #9939

Auditors:

Test Plan:

  • use existing profile from 0.19.x with bookmarks and folder on the toolbar
  • start browser
  • make sure that bookmarks are hidden accordingly when you resize the window

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Resolves brave#9517
Resolves brave#9939

Auditors:

Test Plan:
@NejcZdovc NejcZdovc added this to the 0.20.x (Beta Channel) milestone Jan 22, 2018
@NejcZdovc NejcZdovc self-assigned this Jan 22, 2018
@codecov-io
Copy link

codecov-io commented Jan 22, 2018

Codecov Report

Merging #12768 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #12768      +/-   ##
==========================================
- Coverage   56.13%    56.1%   -0.03%     
==========================================
  Files         279      279              
  Lines       27309    27316       +7     
  Branches     4442     4443       +1     
==========================================
- Hits        15329    15327       -2     
- Misses      11980    11989       +9
Flag Coverage Δ
#unittest 56.1% <100%> (-0.03%) ⬇️
Impacted Files Coverage Δ
app/browser/reducers/bookmarkToolbarReducer.js 100% <100%> (ø) ⬆️
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️
app/renderer/components/reduxComponent.js 84.61% <0%> (-6.16%) ⬇️
js/stores/windowStore.js 27.25% <0%> (-0.31%) ⬇️

@bsclifton
Copy link
Member

Having a problem with this one ☹️ When window is wider than ~1,138 pixels, it seems like the >> doesn't always show
bookmark-overflow

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See feedback

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With your latest updates, this works great 😄 👍 Thanks for fixing the edge case

@bsclifton bsclifton merged commit 8d4531e into brave:master Jan 25, 2018
bsclifton added a commit that referenced this pull request Jan 25, 2018
Fixes upgrade of bookmark/folder width
bsclifton added a commit that referenced this pull request Jan 25, 2018
Fixes upgrade of bookmark/folder width
@bsclifton
Copy link
Member

master 8d4531e
0.21.x bcd2de6
0.20.x 48dfb13

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants