Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Move bookmark text calculation into the state #9517

Closed
NejcZdovc opened this issue Jun 16, 2017 · 3 comments
Closed

Move bookmark text calculation into the state #9517

NejcZdovc opened this issue Jun 16, 2017 · 3 comments
Assignees
@NejcZdovc
Labels
feature/bookmarks QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 16, 2017 •
edited by luixxiul
Loading

Test plan

#12768 (comment)

Describe the issue you encountered:
Move calculation of bookmark width into state and calculate it only when bookmark is added/edited or favicon setting for bookmark toolbar is changes

#9030
@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 16, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 16, 2017
@NejcZdovc NejcZdovc mentioned this issue Jun 16, 2017
Merged
7 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 20, 2017
@NejcZdovc
Moves bookmark item width into the state
a4c5416 
Resolves brave#9517

Auditors: @bsclifton @bridiver @ayumi

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jun 20, 2017
Closed
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 26, 2017
@NejcZdovc
Moves bookmark item width into the state
be4498e 
Resolves brave#9517

Auditors: @bsclifton @bridiver @ayumi

Test Plan:
@NejcZdovc NejcZdovc removed this from the 0.19.x (Nightly Channel) milestone Jun 28, 2017
@NejcZdovc NejcZdovc added this to the Backlog milestone Jul 9, 2017
@NejcZdovc NejcZdovc removed their assignment Jul 9, 2017
@NejcZdovc NejcZdovc mentioned this issue Aug 11, 2017
Merged
8 tasks
@NejcZdovc NejcZdovc self-assigned this Aug 11, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Nightly Channel), Backlog Aug 11, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 11, 2017
@NejcZdovc
Moves bookmark text calculation into the state
293957c 
Resolves brave#9517

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 15, 2017
@NejcZdovc
Moves bookmark text calculation into the state
8ef275c 
Resolves brave#9517

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 15, 2017
@NejcZdovc
Moves bookmark text calculation into the state
ff49fdd 
Resolves brave#9517

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 15, 2017
@NejcZdovc
Moves bookmark text calculation into the state
c58aeca 
Resolves brave#9517

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 15, 2017
@NejcZdovc
Moves bookmark text calculation into the state
59405bb 
Resolves brave#9517

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 16, 2017
@NejcZdovc
Moves bookmark text calculation into the state
9466f72 
Resolves brave#9517

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 18, 2017
@NejcZdovc
Moves bookmark text calculation into the state
b053ac6 
Resolves brave#9517

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 25, 2017
@NejcZdovc
Moves bookmark text calculation into the state
16cf037 
Resolves brave#9517

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 25, 2017
@NejcZdovc
Moves bookmark text calculation into the state
c8c3df3 
Resolves brave#9517

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 29, 2017
@NejcZdovc
Moves bookmark text calculation into the state
d51ae65 
Resolves brave#9517

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 5, 2017
@NejcZdovc
Moves bookmark text calculation into the state
43322d6 
Resolves brave#9517

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 6, 2017
@NejcZdovc
Moves bookmark text calculation into the state
676f070 
Resolves brave#9517

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 6, 2017
@NejcZdovc
Moves bookmark text calculation into the state
cfd62bb 
Resolves brave#9517

Auditors:

Test Plan:
@ghost ghost added the sprint/1 label Sep 13, 2017
@srirambv srirambv mentioned this issue Dec 20, 2017
Closed
27 tasks
This was referenced Dec 27, 2017
Closed
Closed
Closed
This was referenced Jan 2, 2018
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Jan 3, 2018 •
edited
Loading

Bookmark overflow indicator is not always displayed on MacOS:
9517

@LaurenWags LaurenWags reopened this Jan 3, 2018
@NejcZdovc
Copy link
Contributor Author

@LaurenWags I tried it with a fresh profile and imported bookmarks, but I can't reproduce it.

jan-09-2018 12-23-54

@NejcZdovc
Copy link
Contributor Author

ok I think that I found the problem. It's not working with the existing profile.

@cezaraugusto cezaraugusto mentioned this issue Jan 9, 2018
Closed
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 22, 2018
@NejcZdovc
Fixes upgrade of bookmark/folder width
956108e 
Resolves brave#9517
Resolves brave#9939

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jan 22, 2018
Merged
10 tasks
bsclifton pushed a commit to NejcZdovc/browser-laptop that referenced this issue Jan 22, 2018
@NejcZdovc @bsclifton
Fixes upgrade of bookmark/folder width
05cd2c3 
Resolves brave#9517
Resolves brave#9939

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Jan 25, 2018
@bsclifton
Merge pull request #12768 from NejcZdovc/hotfix/#9517-update
8d4531e 
Fixes upgrade of bookmark/folder width
bsclifton added a commit that referenced this issue Jan 25, 2018
@bsclifton
Merge pull request #12768 from NejcZdovc/hotfix/#9517-update
bcd2de6 
Fixes upgrade of bookmark/folder width
bsclifton added a commit that referenced this issue Jan 25, 2018
@bsclifton
Merge pull request #12768 from NejcZdovc/hotfix/#9517-update
48dfb13 
Fixes upgrade of bookmark/folder width
This was referenced Jan 29, 2018
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Jan 29, 2018
Closed
@srirambv srirambv mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/bookmarks QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
6 participants
@bbondy @luixxiul @bsclifton @NejcZdovc @srirambv @LaurenWags