This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Converts bookmarksToolbar and bookmarkToolbarButton into redux #9030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luixxiul this is not ready for a review |
NejcZdovc
force-pushed
the
redux/bookmarks
branch
from
a3d9ee0 to
8479c8c
Compare
NejcZdovc
modified the milestones:
0.18.x,
0.17.x (Frozen, only critical adds from here)
51 tasks
NejcZdovc
force-pushed
the
redux/bookmarks
branch
from
8479c8c to
9b0c1a9
Compare
|
blocked on #9176 |
NejcZdovc
modified the milestones:
0.19.x (Nightly Channel),
0.18.x (Developer Channel)
NejcZdovc
force-pushed
the
redux/bookmarks
branch
from
9b0c1a9 to
3af4af3
Compare
NejcZdovc
force-pushed
the
redux/bookmarks
branch
from
3af4af3 to
341aa7c
Compare
NejcZdovc
force-pushed
the
redux/bookmarks
branch
4 times, most recently
from
e21ade1 to
eaa5d50
Compare
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this pull request
Jun 20, 2017
Resolves brave#9030 Auditors: @bsclifton @bridiver @ayumi Test Plan:
NejcZdovc
force-pushed
the
redux/bookmarks
branch
from
eaa5d50 to
92b3067
Compare
NejcZdovc
force-pushed
the
redux/bookmarks
branch
from
92b3067 to
0532b52
Compare
|
@darkdh can you please check out why we still need this line https://github.com/brave/browser-laptop/pull/9030/files#diff-5da1a3da6effd6fc765f3f68b7162215R34 even though that this shouldn't be needed, because of this PR #8075. Note that we are getting state now directly. Is it possible, that there is an delay (state is updated, but not sorted immediately) and because of that mergeProps get the old sort and because bookmarks are the same (after state sort is done) we don't trigger re-render? |
|
sure, will look at it soon |
bridiver
reviewed
Jun 23, 2017
app/common/state/bookmarksState.js
Outdated
| return { | ||
| visibleBookmarks: noParentItems.take(i), | ||
| // Show at most 100 items in the overflow menu | ||
| hiddneBookmarks: noParentItems.skip(i).take(100) |
bridiver
reviewed
Jun 23, 2017
app/common/state/bookmarksState.js
Outdated
| const {iconSize} = require('../../../js/constants/config') | ||
|
|
||
| const bookmarksState = { | ||
| getDNDBookmarkData: (state, bookmark) => { |
There was a problem hiding this comment.
I think these probably make more sense in bookmarkUtil. Bookmarks don't have their own state right now because they are part of sites
bridiver
approved these changes
Jun 23, 2017
NejcZdovc
force-pushed
the
redux/bookmarks
branch
4 times, most recently
from
e3eeff8 to
7c1d22f
Compare
Resolves brave#9421 Auditors: @bsclifton @bridiver Test Plan:
NejcZdovc
force-pushed
the
redux/bookmarks
branch
from
7c1d22f to
5f6f453
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Resolves #9421
Auditors: @bsclifton @bridiver
Note: Follow up for this PR is #9517 (PR #9611)
Test plan:
Reviewer Checklist:
Tests