Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

disable webusb and bluetooth API explicitly #13375

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Mar 2, 2018

disable webusb and bluetooth API

neither are supported, but this will cause sites that check whether
they're supported to know more reliably that they aren't supproted.

fix https://github.com/brave/browser-laptop/issues/13374

fix #13374

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. go to any site and open page console.
  2. navigator.usb should be undefined
  3. navigator.bluetooth should be undefined

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@diracdeltas diracdeltas added this to the 0.22.x (Developer Channel) milestone Mar 2, 2018
@diracdeltas diracdeltas self-assigned this Mar 2, 2018
@diracdeltas diracdeltas requested a review from evq March 2, 2018 22:07
@diracdeltas diracdeltas mentioned this pull request Mar 6, 2018
neither are supported, but this will cause sites that check whether
they're supported to know more reliably that they aren't supproted.

fix #13374

Test Plan:
1. go to any site and open page console.
2. navigator.usb should be undefined
3. navigator.bluetooth should be undefined
Copy link
Member

@evq evq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, test plan passes

@diracdeltas diracdeltas changed the title disable webusb API disable webusb and bluetooth API explicitly Mar 7, 2018
@diracdeltas diracdeltas merged commit 5143bd3 into master Mar 7, 2018
diracdeltas added a commit that referenced this pull request Mar 7, 2018
disable webusb and bluetooth API explicitly
diracdeltas added a commit that referenced this pull request Mar 7, 2018
disable webusb and bluetooth API explicitly
@diracdeltas
Copy link
Member Author

master: 5143bd3
0.23.x: cfa51af
0.22.x: 768bfd6

@bsclifton bsclifton deleted the fix/disable-webusb branch March 9, 2018 07:06
@btlechowski
Copy link
Contributor

Verified on Windows 7 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable webusb API
3 participants