Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Don't consider openableByContextMenu if URL is falsey #15061

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Don't consider openableByContextMenu if URL is falsey #15061

merged 1 commit into from
Aug 20, 2018

Conversation

bsclifton
Copy link
Member

Fixes #15057

Auditors: @diracdeltas

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton self-assigned this Aug 20, 2018
@bsclifton bsclifton requested a review from diracdeltas August 20, 2018 17:03
@bsclifton bsclifton merged commit 4638516 into brave:master Aug 20, 2018
@bsclifton bsclifton deleted the fix-new-tab branch August 20, 2018 18:05
bsclifton added a commit that referenced this pull request Aug 20, 2018
@bsclifton
Merge pull request #15061 from bsclifton/fix-new-tab
3c8cac2 
Don't consider openableByContextMenu if URL is falsey
bsclifton added a commit that referenced this pull request Aug 20, 2018
@bsclifton
Merge pull request #15061 from bsclifton/fix-new-tab
ffb14e0 
Don't consider openableByContextMenu if URL is falsey
@bsclifton
Copy link
Member Author

master 4638516
0.24.x 3c8cac2
0.23.x ffb14e0

diracdeltas added a commit that referenced this pull request Sep 12, 2018
@diracdeltas
Fix about:blank appearing on new tab in new windows
602f1aa 
fix #15162

openableByContextMenu returned false if URL is empty for paranoia
reasons, but it turns out this breaks some edge cases. See
#15061 for instance.

Test Plan:
1. unit tests pass
2. on MacOS, close all windows
3. click 'open in new tab'
4. new window should appear and show the new tab page
5. repeat step 3 and 4 with private tab, tor tab, session tab
@diracdeltas diracdeltas mentioned this pull request Sep 12, 2018
Merged
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@diracdeltas diracdeltas diracdeltas approved these changes

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
0.23.x Release 5 (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@bsclifton @diracdeltas