Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix about:blank appearing on new tab in new windows #15194

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Sep 12, 2018

fix #15162

openableByContextMenu returned false if URL is empty for paranoia
reasons, but it turns out this breaks some edge cases. See
#15061 for instance.

Test Plan:

  1. unit tests pass
  2. on MacOS, close all windows
  3. click 'New tab'
  4. new window should appear and show the new tab page
  5. repeat step 3 and 4 with private tab, tor tab, session tab, and new window

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

fix #15162

openableByContextMenu returned false if URL is empty for paranoia
reasons, but it turns out this breaks some edge cases. See
#15061 for instance.

Test Plan:
1. unit tests pass
2. on MacOS, close all windows
3. click 'open in new tab'
4. new window should appear and show the new tab page
5. repeat step 3 and 4 with private tab, tor tab, session tab
@bsclifton
Copy link
Member

When reviewing, I'll check if this fixes #15134 also

@diracdeltas
Copy link
Member Author

pretty sure it won't fix #15134 since that relates to file:/// URLs

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 😄 👍

@bsclifton bsclifton merged commit 141e002 into master Sep 13, 2018
@bsclifton bsclifton deleted the fix/15162 branch September 13, 2018 07:30
bsclifton added a commit that referenced this pull request Sep 13, 2018
Fix about:blank appearing on new tab in new windows
bsclifton added a commit that referenced this pull request Sep 13, 2018
Fix about:blank appearing on new tab in new windows
@bsclifton
Copy link
Member

master 141e002
0.24.x 1f1f1d9
0.23.x c5dd2a9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opening tabs, PT, session tabs opens about:blank when there's no Win/Tabs opened
2 participants