This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
0.24.x (Chromium 69) #15209
Merged
0.24.x (Chromium 69) #15209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auditors: @bridiver
only fire once each scroll since C69 mainly fix #15114 also fix #14871 fix #14829 fix #14785 Auditor: @bsclifton
Auditors: @bridiver
Auditors: @bsclifton
depends on brave/muon@b9cec60 Auditors: @bsclifton
Auditors: @darkdh
Auditors: @kjozwiak
bsclifton
requested review from
btlechowski,
GeetaSarvadnya,
kjozwiak,
LaurenWags and
srirambv
September 18, 2018 17:50
@bsclifton QA finished going through the following manual passes:
QA has spot checked @srirambv @LaurenWags @btlechowski @GeetaSarvadnya can you please confirm that the |
Spot check on Windows looks good 👍 |
srirambv
approved these changes
Sep 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Performed high level testing on all the functionalities for 0.24.0, did not find any major issues. Windows looks good. |
spot checks on macOS looked good - no new issues found. |
Spot checked Linux. LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a work in progress; this has all the feature work for the following milestone:
https://github.com/brave/browser-laptop/milestone/125
Don't merge until QA approved 😄