Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes #2914: Pressing Esc key activates the URL Bar #2920

Closed
wants to merge 1 commit into from
Closed

Fixes #2914: Pressing Esc key activates the URL Bar #2920

wants to merge 1 commit into from

Conversation

willy-b
Copy link
Contributor

@willy-b willy-b commented Aug 3, 2016

@bbondy
Copy link
Member

bbondy commented Aug 9, 2016

k passing to @bridiver to review

@bridiver
Copy link
Collaborator

bridiver commented Aug 9, 2016

I noticed that some of the existing tests weren't running because of overlapping definitions. I'm fixing that now and then I'll get back to this PR

bridiver added a commit that referenced this pull request Aug 9, 2016
@bridiver
fix urlbar escape tests and behavior
f551bbd 
fixes #2914
related #2920
cc @bbondy @willy-b
@bridiver bridiver mentioned this pull request Aug 9, 2016
Merged
3 tasks
@bridiver
Copy link
Collaborator

bridiver commented Aug 9, 2016

#3057

@bbondy
Copy link
Member

bbondy commented Aug 9, 2016

I think this is superseded by the above so will close this. Sorry about that.

@bbondy bbondy closed this Aug 9, 2016
@willy-b
Copy link
Contributor Author

willy-b commented Aug 9, 2016 •
edited
Loading

Haha, it's all good -- the bug is fixed and with tests! no "sorry" needed :-D. This was a zero effort 1-line change in any case.

@gulkily gulkily mentioned this pull request Aug 18, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willy-b @bbondy @bridiver