This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Don't show HTTP icon while site is loading (since it may be HTTPS) #5498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5490 Includes breaking the urlbar icon into it's own control (along with click/drag events) Auditors: @jkup, @bbondy Test Plan: 1. Launch Brave and open a new tab 2. Type in "https://twitter.com" and get really close to your screen 3. Hit enter and notice you do not see the yellow triangle at any time
|
i still see the insecure icon flash briefly. possibly before how about, after the 'enter' key is pressed, show no icon at all until the load is started? |
|
edit: repro'd |
|
@bsclifton i went to the https url directly but it still showed the insecure icon. i think if one goes to the insecure version, it should show the insecure icon because the browser does in fact make an insecure network connection. |
|
I'm going to merge this for now since it mitigates the issue but i'll keep the issue open and create another PR on top of it using brave/muon#90 |
This was referenced Nov 10, 2016
luixxiul
added
feature/URLbar
and removed
QA/checked-macOS
QA/checked-Linux
QA/checked-Win32
QA/checked-Win64
release/blocking
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Don't show HTTP icon while site is loading (since it may be HTTPS)
Fixes #5490
Includes breaking the urlbar icon into it's own control (along with click/drag events)
Auditors: @diracdeltas, @jkup, @bbondy
Test Plan: