This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Setting location for a frame will now set loading=true #5502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this OK? Usually, it gets set to true in WindowStore:: WINDOW_WEBVIEW_LOAD_START The only places I see this used are: - navigationBar (which binds to urlBar, which then binds to urlBarIcon (where the problem is)) - tabs (used to show the loading spinner) Auditors: @diracdeltas, @bridiver
|
this seems like it would potentially trigger the loading indication when a load hasn't really started. I think the loading state should only be triggered by the loading events or we will end up with odd behavior and load indicators that never stop |
|
@diracdeltas I'm going to go ahead and close this, per @bridiver's comment. I'm definitely scared of a regression and am not in a hurry to fix this. I'll keep an eye out for your electron change 😄 |
|
and here it is: 😄 (sorry, I totally missed both the electron change and the WIP PR) |
|
sgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #5498
Problem
Being on a new tab and then loading a URL would return loading: false, even after the location is updated.
Resolution
setting location for a frame will now set loading=true
Is this OK? Usually, it gets set to true in WindowStore:: WINDOW_WEBVIEW_LOAD_START
The only places I see this used are:
Auditors: @diracdeltas, @bridiver