This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add sync #6751
Closed
Add sync #6751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
force-pushed
the
0.13.1-branch
branch
from
5098230 to
187fa9a
Compare
|
I tested this on my browser data, consisting of 241 bookmarks and 525 preferences. It took 30s of beachball spinning to sync over to pyramid 2. That's probably okay for now, but we should improve the UX soon. brave/sync#44 Edit: This is fixed now. |
|
Rebase needed |
ayumi
force-pushed
the
feature/syncing-0.13.1
branch
from
6402409 to
863e095
Compare
|
Rebased to |
|
Please create an associated issue ;-) thanks |
bsclifton
force-pushed
the
0.13.1-branch
branch
from
bd9183d to
2789018
Compare
ayumi
force-pushed
the
feature/syncing-0.13.1
branch
from
3f7066e to
667aa17
Compare
|
Rebased to Bookmark folders might have issues when syncing (should be resolved by brave/sync#47 and brave/sync#48 ) Regular bookmarks, history and site settings (eg Shields up/down) should sync correctly. |
Resolves #6402 Auditors: @bsclifton Test Plan: -Go to link in the issue -Select link -Right click on text selection -Context menu for link should appear
Fix #6217 Auditors: @bsclifton
Considering the context menus disappear on the mousedown event I added hamburgerMenuWasOpen to the windowState to be able to check it when the hamburgerMenu's onClick is executed Closes #4921
The added tests test that the hamburgerMenu's context menu appears, disappears, reappears on different clicks
Fixes ##5828 Auditors: @bsclifton @echosa Test Plan: - Build brave - Open local file with brave (double click) - Local file should be opened
Deletes "Report an Issue" menu item because both it and "Submit Feedback" link to community.brave.com. Resolves #6180
Resolves #6180 Auditors: Test Plan:
This adds most of the UX for Brave sync setup in the case where this device is the first device in the sync profile. Auditors: @ayumi Test Plan: 1. npm run clean-session-store 2. npm start 3. go to about:preferences#sync 4. click the orange button to set up sync for the first time 5. name the device, then click the create button 6. shut down brave, run npm start again 7. you should see the device name from (5) in the terminal console 8. go to about:preferences#sync, click 'add new device' button 9. you should see a QR code
Auditors: @diracdeltas
Auditors: @diracdeltas Test Plan: Prep: 0. Update sync lib to `brave/sync #fix/resolve-delete-nonexistant-props`. 1. Prepare 2 instances (pyramids) of Brave with Sync enabled. - Enable Sync and close Brave. - Copy `{userData}/brave-development` to `{userData}/brave-development-2`. - Edit `brave-development-2/session-store-1` `deviceId` to `1`. - To `browser-laptop` `package.json` add `"start2": "node ./tools/start.js --user-data-dir=brave-development-2 --debug=5859 --enable-logging --v=0 --enable-extension-activity-logging --enable-sandbox-logging --enable-dcheck",` 2. In `appConfig.js` `sync.fetchInterval` reduce to 5 seconds. Play: 3. Open both pyramid 1 and pyramid 2. 4. In pyramid 1 visit a webpage and open up the bravery panel. 5. In pyramid 2 visit the same page and open up the bravery panel. 6. In pyramid 2 toggle each available siteSetting. Observe it appears in pyramid 1 after 1–5s. 7. Try toggling multiple settings at once, and toggling different settings simulatenously on both pyramids. 8. In both go to Preferences #Shields. Clear siteSettings with the Clear links and the red X's. Observe they sync over.
by entering the 16 code words
Auditors: @diracdeltas Test Plan: 1. Have Sync disabled. 2. Browse a site and toggle a Bravery Panel setting. 3. Enable Sync and restart your pyramid. Note that siteSettings are sent. 4. Restart your pyramid again. Note this time siteSettings are *not* sent.
Fix brave/sync#44 Auditors: @diracdeltas Test Plan: 1. Start Pyramid 1 which has a bunch of syncable data. Sync should enabled. 2. Setup Pyramid 2 (add `"start2": "node ./tools/start.js --user-data-dir=brave-development-2 --debug=5859 --enable-logging --v=0 --enable-extension-activity-logging --enable-sandbox-logging --enable-dcheck",` to package.json) and specify the Pyramid 1 Sync credentials. 3. When Pyramid 2 restarts and begins syncing data, Brave should be somewhat usable (not completely frozen for 60s).
ayumi
force-pushed
the
feature/syncing-0.13.1
branch
from
667aa17 to
322cac5
Compare
|
Rebased on |
bsclifton
force-pushed
the
0.13.1-branch
branch
2 times, most recently
from
65c7753 to
238cfd3
Compare
bsclifton
force-pushed
the
0.13.1-branch
branch
from
67b2326 to
5eb09be
Compare
|
@bsclifton is this supposed to be rebased on master now? |
|
0.13.1 is now merged 😄 Sorry for all the rebasing you've had to do to keep up with the merges. You all should be good now 👍 |
Merged
|
closing in favor of #6882 which is against master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds basic support for browser sync, using https://github.com/brave/sync
Fix #1854
Test Plan:
setup
npm installto add dependenciesnpm run download-sync-clientto download the sync client to the right subdirectorytest
todos before public release (not necessarily before merge)