-
Notifications
You must be signed in to change notification settings - Fork 973
Conversation
Also show device name Auditors: @diracdeltas
f9026e6
to
7dad719
Compare
[minor] the large right-side padding is a little weird some of the syncing tests are unstoked https://travis-ci.org/brave/browser-laptop/builds/200218416#L4843 |
font-size: 18px; | ||
font-family: monospace; | ||
.browserButton + .browserButton { | ||
margin-left: 0.75em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be already covered with
browser-laptop/less/button.less
Line 52 in 2aa39bb
& + .browserButton { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5px was insufficient :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surely!
@@ -56,7 +65,7 @@ class SyncTab extends ImmutableComponent { | |||
} | |||
return this.props.syncQRVisible | |||
? <div> | |||
<div><Button l10nId='syncHideQR' className='whiteButton syncToggleButton' onClick={this.props.hideQR} /></div> | |||
<div><Button l10nId='syncHideQR' className='whiteButton wideButton syncToggleButton' onClick={this.props.hideQR} /></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need wideButton
for this? the min-width of the buttons has been set globally with #6387
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied this class as a hack to make the "button pressed / secret visible" state have a larger button. wideButton might be inappropriate so I can explicitly set a width for these buttons.
@@ -76,7 +85,7 @@ class SyncTab extends ImmutableComponent { | |||
] | |||
return this.props.syncPassphraseVisible | |||
? <div> | |||
<Button l10nId='syncHidePassphrase' className='whiteButton syncToggleButton' onClick={this.props.hidePassphrase} /> | |||
<Button l10nId='syncHidePassphrase' className='whiteButton wideButton syncToggleButton' onClick={this.props.hidePassphrase} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
@diracdeltas ran tests again which were successful. the test failures look to be intermittent and I'll try to address that in a separate PR. |
also show device name
Auditors: @diracdeltas