This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Use <SettingTextbox> for the textbox on the dialog of enabling Sync #7164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change will make the input form into:
|
luixxiul
commented
Feb 10, 2017
| @@ -1589,9 +1589,7 @@ table.sortableTable { | |||
| .setupContent { | |||
| margin: 1em 0; | |||
| } | |||
| .deviceNameInput { | |||
| width: 50%; | |||
There was a problem hiding this comment.
Please let me know if this should not be removed. <SettingTextbox> has its own width.
Merged
ayumi
reviewed
Feb 10, 2017
| @@ -117,7 +118,9 @@ class SyncTab extends ImmutableComponent { | |||
| : getSetting(settings.SYNC_DEVICE_NAME, this.props.settings) | |||
| return <SettingItem> | |||
| <span data-l10n-id='syncDeviceNameInput' /> | |||
| <input className='deviceNameInput formControl' spellCheck='false' | |||
| <SettingTextbox | |||
There was a problem hiding this comment.
Earlier I tried to use a Textbox however I couldn't get the prop ref={} to work so the input didn't work[0]. I gave up and used a standard input.
This branch doesn't seem to set the device name either.
[0] Maybe this: https://facebook.github.io/react/docs/refs-and-the-dom.html
Test Plan:
- Clear profile
- Enable sync and name the device
- Observe terminal for the device name– should not be "browser-laptop"
Also tested by: yarn test -- --grep='"^Sync Panel"'
ayumi
reviewed
Feb 10, 2017
less/forms.less
Outdated
| @@ -766,6 +766,7 @@ select { | |||
| } | |||
|
|
|||
| // From commonStyles.js | |||
| // TODO: remove this after input element in addOverlayContent on syncTab.js is replaced with the new textbox control in Aphrodite | |||
Based on #6882 (comment) Auditors: Test Plan: n/a
…ing using .formControl anymore) Auditors: @luixxiul
|
Hmm, I think as per earlier #7164 (comment) this patch breaks naming devices. The relevant failing test is: |
This was referenced Feb 23, 2017
|
I've reverted this and created #7360 to track the issue. |
4 tasks
luixxiul
pushed a commit
that referenced
this pull request
Apr 23, 2017
- textbox and textbox__outlineable were copied from textbox.js to commonStyles.js Since FormTextbox cannot be used for the input elements, I copied the styles applied for that element and applied to them. See: #7164 (comment) The labels and input forms were grouped and placed with display:flex and justify-content:space-between. Also the elements inside each wrapper were aligned equally to make the length of the input forms always equal (l10n friendly). Also colons in the label were removed to make the style consistent. Closes #8009 Addresses #8010 Auditors: Test Plan: 1. Visit http://browserspy.dk/password.php 2. Click "password-ok.php" link 3. Make sure you can log in successfully with the given credential 4. Change the lang setting on about:preferences 5. Try the same steps above and make sure the length of the input forms is equal
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7152
Based on #6882 (comment)
Auditors: @ayumi @bsclifton
Test Plan: n/a