Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Discard .genericForm and .commonForm from forms.less #8010

Closed
7 tasks done
luixxiul opened this issue Mar 31, 2017 · 0 comments
Closed
7 tasks done

Discard .genericForm and .commonForm from forms.less #8010

luixxiul opened this issue Mar 31, 2017 · 0 comments
Assignees
@luixxiul
Labels
QA/no-qa-needed refactoring/aphrodite refactoring release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Mar 31, 2017 •
edited
Loading

Describe the issue you encountered:
Discard .genericForm. See: #8009 (comment)

Currently there are only three other instances where .genericForm is applied (autofillAddressPanel.js, autofillCreditCardPanel.js, and addEditBookmarkHanger.js), and in every case styles which genericForm defines are overwritten by what commonForm is going to do so (title color, padding inside the dialog, etc). Keeping both of them is a cause of style inconsistency.

Also remove .commonForm from form.less (as it was already refactored into the aphrodite component).

Any related issues: #7989 and #7990
@luixxiul luixxiul self-assigned this Mar 31, 2017
@luixxiul luixxiul mentioned this issue Mar 31, 2017
Merged
4 tasks
This was referenced Apr 6, 2017
Closed
Closed
Closed
Merged
@luixxiul luixxiul added this to the 0.14.3 milestone Apr 10, 2017
@luixxiul luixxiul changed the title Discard .genericForm Discard .genericForm and .commonForm from forms.less Apr 10, 2017
This was referenced Apr 21, 2017
Closed
Merged
Merged
Closed
Merged
luixxiul pushed a commit that referenced this issue Apr 23, 2017
Refactor loginRequired.js with Aphrodite and commonForm
fc34971 
- textbox and textbox__outlineable were copied from textbox.js to commonStyles.js

Since FormTextbox cannot be used for the input elements, I copied the styles applied for that element and applied to them. See: #7164 (comment)

The labels and input forms were grouped and placed with display:flex and justify-content:space-between. Also the elements inside each wrapper were aligned equally to make the length of the input forms always equal (l10n friendly).

Also colons in the label were removed to make the style consistent.

Closes #8009
Addresses #8010

Auditors:

Test Plan:
1. Visit http://browserspy.dk/password.php
2. Click "password-ok.php" link
3. Make sure you can log in successfully with the given credential
4. Change the lang setting on about:preferences
5. Try the same steps above and make sure the length of the input forms is equal
@alexwykoff alexwykoff mentioned this issue May 2, 2017
Closed
21 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
QA/no-qa-needed refactoring/aphrodite refactoring release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
1 participant
@luixxiul