Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor autofillAddressPanel.js with commonForm #8099

Closed
luixxiul opened this issue Apr 6, 2017 · 0 comments
Closed

Refactor autofillAddressPanel.js with commonForm #8099

luixxiul opened this issue Apr 6, 2017 · 0 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Apr 6, 2017

Test plan

9afa06c

  1. Automated tests should pass
  2. Open about:autofill
  3. Add an address
  4. Add a credit card
  5. Visit https://www.roboform.com/filling-test-all-fields
  6. Make sure the input forms can be filled

Describe the issue you encountered:

Refactor autofillAddressPanel.js, replacing .genericForm with commonForm.

@luixxiul luixxiul self-assigned this Apr 6, 2017
@luixxiul luixxiul added this to the 0.14.3 milestone Apr 10, 2017
cezaraugusto pushed a commit that referenced this issue Apr 18, 2017
Closes #8099
Closes #8100
Addresses #7989

- Refactored with commonForm, replacing it with genericForm
  Aligned labels to the left and input textboxes to the right by applying display:flex

- Added CommonFormLarge
- Added cx to dialog.js for more readability
- Removed .manageAutofillDataPanel from form.less

Also:
- Added testIds
- Edited autofillTest.js and autofill.js
  TODO: refactor autofill.js with Aphrodite
- Edited selectors.js

Auditors:

Test Plan:
1. Automated tests should pass
2. Open about:autofill
3. Add an address
4. Add a credit card
5. Visit https://www.roboform.com/filling-test-all-fields
6. Make sure the input forms can be filled
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.