Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Delete genericForm and commonDialog from forms.less #8155

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Delete genericForm and commonDialog from forms.less #8155

merged 1 commit into from
Apr 21, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 9, 2017

Closes #8010
Addresses #7989

Auditors:

Test Plan: n/a

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

@luixxiul luixxiul self-assigned this Apr 9, 2017
@luixxiul luixxiul added this to the 0.14.3 milestone Apr 10, 2017
@luixxiul luixxiul changed the title Delete genericForm from forms.less Delete genericForm and commonDialog from forms.less Apr 10, 2017
Closes #8010
Addresses #7989

Auditors:

Test Plan: n/a
@luixxiul
Copy link
Contributor Author

luixxiul commented Apr 21, 2017

Every PR which has blocked this PR was merged to refactoring-aphrodite, so it should be OK to merge this.

@NejcZdovc
Copy link
Contributor

@luixxiul should we still merge this into refactoring-aphrodite or should we merge it into master already?

@luixxiul
Copy link
Contributor Author

luixxiul commented Apr 21, 2017

It should be merged to refactoring-aphrodite yet. Later I will push the final PR to master.

@NejcZdovc
Copy link
Contributor

Ok, let's merge this one

@NejcZdovc NejcZdovc merged commit c84fd1c into brave:refactoring-aphrodite Apr 21, 2017
@luixxiul luixxiul deleted the delete-genericForm branch April 25, 2017 03:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants