Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

show origin for downloaded URLs #7755

Merged
merged 1 commit into from
Apr 3, 2017
Merged

show origin for downloaded URLs #7755

merged 1 commit into from
Apr 3, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Mar 17, 2017 •
edited by bsclifton
Loading

test plan:

  1. go to https://bing.com, download any of the images. the download bar should appear and show 'https://bing.com' in green.
  2. go to http://thehill.com, download any image. the download bar should show 'http://thehill.com' in red.

screen shot 2017-04-03 at 11 01 37 am

Description

fix #7468

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

@diracdeltas diracdeltas added this to the 0.14.1 milestone Mar 17, 2017
@diracdeltas diracdeltas requested a review from bbondy March 17, 2017 00:52
@diracdeltas diracdeltas mentioned this pull request Mar 17, 2017
Closed
@diracdeltas diracdeltas self-assigned this Mar 24, 2017
@bsclifton bsclifton force-pushed the feature/downloads-origin branch from 4d24855 to 0dd7d4f Compare April 3, 2017 16:51
@bsclifton bsclifton self-requested a review April 3, 2017 18:00
bsclifton
bsclifton approved these changes Apr 3, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great and looks great! 😄 Well done!

@bsclifton bsclifton merged commit 1334948 into master Apr 3, 2017
@bsclifton bsclifton deleted the feature/downloads-origin branch April 3, 2017 18:04
@diracdeltas diracdeltas mentioned this pull request Apr 10, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@diracdeltas diracdeltas

Labels
feature/download QA/test-plan-specified release-notes/include security
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

Added origin display for downloads
2 participants
@diracdeltas @bsclifton