Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added origin display for downloads #7468

Closed
diracdeltas opened this issue Mar 3, 2017 · 3 comments · Fixed by #7755
Closed

Added origin display for downloads #7468

diracdeltas opened this issue Mar 3, 2017 · 3 comments · Fixed by #7755
Assignees
@diracdeltas
Labels
feature/download QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/no-qa-needed QA/test-plan-specified release-notes/include security
Milestone
0.15.0

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Mar 3, 2017 •
edited by luixxiul
Loading

Old title: downloads should show origin #7468 (comment)

test plan:

#7755 (comment)

  1. go to https://bing.com, download any of the images. the download bar should appear and show 'https://bing.com' in green with no icon.
  2. go to http://thehill.com, download any image. the download bar should show 'http://thehill.com' in red with an unlock icon.

we should show the origin that a file is about to be downloaded from, and also address https://bugzilla.mozilla.org/show_bug.cgi?id=741050.
@diracdeltas diracdeltas added this to the 1.0.0 milestone Mar 3, 2017
@bbondy
Copy link
Member

bbondy commented Mar 4, 2017

++ would be great to review open and closed security bugs from other browsers to see how we can improve.

@diracdeltas diracdeltas self-assigned this Mar 16, 2017
diracdeltas added a commit that referenced this issue Mar 17, 2017
@diracdeltas
show origin for downloaded URLs
4d24855 
fix #7468
@diracdeltas diracdeltas mentioned this issue Mar 17, 2017
Merged
4 tasks
@diracdeltas diracdeltas modified the milestones: 0.14.1, 1.0.0 Mar 17, 2017
@alexwykoff alexwykoff mentioned this issue Mar 31, 2017
Closed
82 tasks
bsclifton pushed a commit that referenced this issue Apr 3, 2017
@diracdeltas @bsclifton
show origin for downloaded URLs
0dd7d4f 
fix #7468
This was referenced Apr 9, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Apr 9, 2017
Closed
This was referenced Apr 13, 2017
Closed
Closed
Closed
This was referenced Apr 21, 2017
Closed
Closed
@alexwykoff
Copy link
Contributor

screen shot 2017-04-21 at 8 02 51 pm

This did not display as described on either the Downloads page or the status bar.

@luixxiul
Copy link
Contributor

luixxiul commented Apr 22, 2017 •
edited
Loading

#8215 - 11 days ago

@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title downloads should show origin Added origin display for downloads Apr 25, 2017
@diracdeltas diracdeltas mentioned this issue Sep 25, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
feature/download QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/no-qa-needed QA/test-plan-specified release-notes/include security
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

show origin for downloaded URLs brave/browser-laptop
8 participants
@diracdeltas @bbondy @alexwykoff @luixxiul @cezaraugusto @bsclifton @srirambv @cndouglas