This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Change tab loading icon #8133
Closed
Change tab loading icon #8133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @bradleyrichter for approval 😄 |
bsclifton
approved these changes
Apr 9, 2017
|
Why the double transition? Refresh related?
… On Apr 9, 2017, at 12:26 AM, Brian Clifton ***@***.***> wrote:
@bsclifton approved this pull request.
Changes LGTM 😄
Unrelated to this change... while testing, I saw something I had never noticed before: the transition from regular tab to themed, when the theme is detected. It looks pretty good!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
sorry closed this accidentally while rebasing, created another: #8160 |
|
@bradleyrichter yes- in the example pic, I am reloading the page 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Change tab loading icon
Close #7265
Close #7779
QA Steps:
Interface should match GIF:
(orange on non-themed tabs - same color as title for other cases)