Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Change tab loading icon #8160

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Change tab loading icon #8160

merged 1 commit into from
Apr 10, 2017

Conversation

cezaraugusto
Copy link
Contributor

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Change tab loading icon

Close #7265
Close #7779

npm run test -- --grep="should show a loading icon if page is still loading"

QA Steps:

Interface should match GIF:
(orange on non-themed tabs - same color as title for other cases)

black_bg_loading

- Auditors: @bsclifton
- Close #7265
- Close #7779
@cezaraugusto cezaraugusto added this to the 0.14.2 milestone Apr 10, 2017
@cezaraugusto cezaraugusto self-assigned this Apr 10, 2017
This was referenced Apr 10, 2017
@bbondy
Copy link
Member

bbondy commented Apr 10, 2017

++

@bbondy bbondy merged commit 485336d into brave:master Apr 10, 2017
@jaredbeck
Copy link

I'm running brave 0.15.1 and I don't see a spinner at all. Never have. How do I enable spinners? Thanks.

@cezaraugusto
Copy link
Contributor Author

hey @jaredbeck thanks for checking. It's an issue that happened after this PR and we're tracking already, feel free to keep tracking at #8550

@cezaraugusto cezaraugusto deleted the tabsbar/7265 branch July 25, 2017 07:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants