-
Notifications
You must be signed in to change notification settings - Fork 974
Move NoScript icon into URL bar. This fixes draggability dead area #8236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On normal pages it works great, though on about pages you could not drag the window.
This looks great, have never liked the old no scrip icon 👍 Great job 👍 |
Will add this to my test for the next version of 0.14.2 👍 |
da040df
to
76633ae
Compare
Great catch, @luixxiul! I just pushed a fix, can you try it? |
some |
76633ae
to
53baebf
Compare
@diracdeltas good catch! 😄 Thanks- will check those out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this icon size and positioning. TY!
…at was present Fixes #5792 Auditors: @bradleyrichter, @luixxiul Includes: Fix noscript tests Auditors: @diracdeltas
53baebf
to
d01daf4
Compare
@diracdeltas fixed! 😄 |
NoScript tests passed- merging! |
Test plan
Description
Fixes #5792
Auditors: @bradleyrichter, @luixxiul
git rebase -i
to squash commits (if needed).