Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added noscript into the URL bar - Move noscript into the URL bar #5792

Closed
bradleyrichter opened this issue Nov 22, 2016 · 11 comments
Closed

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Nov 22, 2016

Red square highlighted below is not draggable because of the no-script icon (even if it's not shown)
image

It should be moved into the URL bar

Test plan

  1. Make sure the non-draggable area specified in Added noscript into the URL bar - Move noscript into the URL bar #5792 is draggable
  2. Make sure every button on the navigation bar is clickable
  3. Open https://jsfiddle.net/
  4. Block scripts from the top right lion icon
  5. Make sure the noScript button on the navigation bar is clickable
@bradleyrichter
Copy link
Contributor Author

This is only present on new-tab and brave about:pages.

@cndouglas
Copy link

cndouglas commented Nov 22, 2016

It's an empty browser button:

<div class="endButtons">
  <span class="browserButton"></span>
</div>

It exists on all pages, but it only becomes larger when on about: pages. 😕

@bbondy
Copy link
Member

bbondy commented Dec 1, 2016

@bsclifton I think you added that button previously, (not sure sorry if not!! :)) could you take a look?

@bradleyrichter
Copy link
Contributor Author

@bsclifton we need to move this button inside the URL bar and use the new icon from the PNG sprite.

@bsclifton
Copy link
Member

Moving this to 0.13.1 (which is where the sprite issue currently is)

@bsclifton bsclifton modified the milestones: 0.13.1, 0.13.0 Dec 3, 2016
luixxiul referenced this issue Dec 21, 2016
…ion buttons. This is especially important for Windows, because its BrowserWindow is using the FramelessWindow.

Fixes #6253

Auditors: @bbondy, @luixxiul
@bbondy
Copy link
Member

bbondy commented Dec 21, 2016

@luixxiul could you verify if this works now? If so pls move to 0.13.0 and close.

@luixxiul
Copy link
Contributor

I thought it cannot be closed yet (as the empty browserButton issue @liunkae mentioned above is not resolved) / cc: @bsclifton for a comment

@cndouglas
Copy link

The empty button still exists, but the zone can now be dragged.

@srirambv
Copy link
Collaborator

Still an issue with 0.13.0 RC1
5792

@bbondy should this be moved to 0.13.1 ?

@srirambv srirambv reopened this Jan 20, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Jan 20, 2017

This has been fixed just accidentally and it was reverted by fixing #6680

I found the cause. I'll fix it quite soon

@luixxiul luixxiul modified the milestones: 0.13.2, 0.13.1 Jan 29, 2017
@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
@bradleyrichter bradleyrichter added this to the 0.14.2 milestone Apr 10, 2017
@bsclifton bsclifton changed the title Dead area in grab zone Move noscript into the URL bar Apr 11, 2017
bsclifton added a commit that referenced this issue Apr 11, 2017
…at was present

Fixes #5792

Auditors: @bradleyrichter, @luixxiul

Includes: Fix noscript tests
Auditors: @diracdeltas
bsclifton added a commit that referenced this issue Apr 11, 2017
…at was present

Fixes #5792

Auditors: @bradleyrichter, @luixxiul

Includes: Fix noscript tests
Auditors: @diracdeltas
@alexwykoff alexwykoff changed the title Move noscript into the URL bar Added noscript into the URL bar Apr 25, 2017
@luixxiul luixxiul changed the title Added noscript into the URL bar Added noscript into the URL bar - Move noscript into the URL bar Apr 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.