-
Notifications
You must be signed in to change notification settings - Fork 974
Added noscript into the URL bar - Move noscript into the URL bar #5792
Comments
This is only present on new-tab and brave about:pages. |
It's an empty browser button: <div class="endButtons">
<span class="browserButton"></span>
</div> It exists on all pages, but it only becomes larger when on about: pages. 😕 |
@bsclifton I think you added that button previously, (not sure sorry if not!! :)) could you take a look? |
@bsclifton we need to move this button inside the URL bar and use the new icon from the PNG sprite. |
Moving this to 0.13.1 (which is where the sprite issue currently is) |
@luixxiul could you verify if this works now? If so pls move to 0.13.0 and close. |
I thought it cannot be closed yet (as the empty browserButton issue @liunkae mentioned above is not resolved) / cc: @bsclifton for a comment |
The empty button still exists, but the zone can now be dragged. |
Still an issue with 0.13.0 RC1 @bbondy should this be moved to 0.13.1 ? |
This has been fixed just accidentally and it was reverted by fixing #6680 I found the cause. I'll fix it quite soon |
…at was present Fixes #5792 Auditors: @bradleyrichter, @luixxiul
…at was present Fixes #5792 Auditors: @bradleyrichter, @luixxiul
…at was present Fixes #5792 Auditors: @bradleyrichter, @luixxiul
…at was present Fixes #5792 Auditors: @bradleyrichter, @luixxiul
…at was present Fixes #5792 Auditors: @bradleyrichter, @luixxiul Includes: Fix noscript tests Auditors: @diracdeltas
…at was present Fixes #5792 Auditors: @bradleyrichter, @luixxiul Includes: Fix noscript tests Auditors: @diracdeltas
Red square highlighted below is not draggable because of the no-script icon (even if it's not shown)
It should be moved into the URL bar
Test plan
The text was updated successfully, but these errors were encountered: