Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

switch from node-uuid to uuid #8668

Merged
merged 1 commit into from
May 5, 2017
Merged

switch from node-uuid to uuid #8668

merged 1 commit into from
May 5, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented May 3, 2017 •
edited
Loading

fix #8667

Test Plan:
N/A

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

@diracdeltas diracdeltas added this to the 0.15.3 milestone May 3, 2017
@diracdeltas diracdeltas self-assigned this May 3, 2017
@diracdeltas diracdeltas requested review from mrose17 and bbondy May 3, 2017 21:24
mrose17
mrose17 approved these changes May 3, 2017
View reviewed changes
Copy link
Member

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bbondy
Copy link
Member

bbondy commented May 5, 2017

++

@bbondy bbondy merged commit 5c6e5c2 into master May 5, 2017
@luixxiul luixxiul deleted the fix/uuid branch May 5, 2017 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrose17 mrose17 mrose17 approved these changes

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@diracdeltas diracdeltas

Labels
None yet
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging this pull request may close these issues.

switch from node-uuid to uuid
3 participants
@diracdeltas @bbondy @mrose17