Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Re-allow dragging bookmarks inside folder in bookmarks manager #9199

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Re-allow dragging bookmarks inside folder in bookmarks manager #9199

merged 1 commit into from
Jun 5, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Jun 1, 2017 •
edited by bsclifton
Loading

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Issue was unintentionally introduced in 21cfbf6#diff-157c36d119068b19baef9bde2ec07f22R62. getSiteKey method expects an Immutable object and converting to JS led method to get a null property.

Auditors: @bsclifton
Fix #9101
Fix #8946

Test Plan:

  1. Have some bookmarks folders with bookmarks inside
  2. Go to about:bookmarks
  3. Right-hand side, drag a bookmark inside a folder
  4. Go to folder, bookmark should be there

Reviewer Checklist:

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@cezaraugusto
Re-allow dragging bookmarks inside folder in about:bookmarks
4320091 
Auditors: @bsclifton
Fix #9101
Fix #8946
Test plan:
Dragging a bookmark inside a folder should be allowed
@cezaraugusto cezaraugusto self-assigned this Jun 1, 2017
@cezaraugusto cezaraugusto requested a review from bsclifton June 1, 2017 19:33
@eljuno eljuno mentioned this pull request Jun 3, 2017
Closed
@bsclifton bsclifton mentioned this pull request Jun 5, 2017
Closed
bsclifton
bsclifton approved these changes Jun 5, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested; works great 😄 ++

@capouch capouch mentioned this pull request Jun 5, 2017
Closed
@bsclifton bsclifton merged commit 5be0d67 into brave:master Jun 5, 2017
bsclifton added a commit that referenced this pull request Jun 5, 2017
@bsclifton
Merge pull request #9199 from cezaraugusto/bookmarks/dnd/9101
520a764 
Re-allow dragging bookmarks inside folder in bookmarks manager
bsclifton added a commit that referenced this pull request Jun 5, 2017
@bsclifton
Merge pull request #9199 from cezaraugusto/bookmarks/dnd/9101
3014c3d 
Re-allow dragging bookmarks inside folder in bookmarks manager
@cezaraugusto cezaraugusto deleted the bookmarks/dnd/9101 branch June 5, 2017 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
feature/bookmarks misc/drag-and-drop
Projects
None yet
Milestone
0.16.x (Frozen, only critical adds fr...
Development

Successfully merging this pull request may close these issues.
2 participants
@cezaraugusto @bsclifton